Closed
Bug 881137
Opened 11 years ago
Closed 11 years ago
hdpi/xhdpi resolution assets and layout for Calendar app
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(blocking-b2g:hd+, firefox25 fixed, b2g18 wontfix, b2g-v1.1hd fixed)
VERIFIED
FIXED
blocking-b2g | hd+ |
People
(Reporter: timdream, Assigned: evanxd)
References
Details
(Whiteboard: [NO_UPLIFT])
Attachments
(3 files)
This bug represents fixes needed in Calendar app in order to deliver bug 881126: -- Have visual supply us with @1.5x and the correct @2x images. -- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly. -- On master, drop the @1.5x and @2x images and make sure there is no more to tweak besides changes made on bug 830644. As HIDPI support never landed on v1-train, I expect the patch for both branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is where the engineering work lays. The patch on top of v1-train should land on v1.1hd.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → evanxd
Assignee | ||
Comment 2•11 years ago
|
||
Hi James, Please help me review the patch. This bug aims to achieve similar goal with bug 830644 on v1.1.0hd branch. Since we need some specified step to try on WVGA device (partial can be tested on Nightly), if you care about the changes and would like to do a full review, you may set review flag after reviewing; otherwise, you may set feedback flag and let me find an appropriate reviewer in Taipei to review and confirm on WVGA device. These 1.5x assets in patch are here temporarily for confirming we're making right layout changes, and will be replaced later after visual team supplying newly made 1.5x assets. The step for testing by HD is noted in Github comment. Thanks a lot.
Attachment #770094 -
Flags: review?(jlal)
Comment 3•11 years ago
|
||
Comment on attachment 770094 [details]
The PR is for master
I don't have a real device to test this against so I will assume that this works as in nightly ( which I did test ) and that it looks good there ( you did the testing ).
Nice work r=me
Attachment #770094 -
Flags: review?(jlal) → review+
Comment 4•11 years ago
|
||
in master: https://github.com/mozilla-b2g/gaia/commit/94a4360d93240d3255658ba65047808794da3cc6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 770094 [details]
The PR is for master
Hi Rex,
Please help review the path with the real device.
Thanks. :)
Attachment #770094 -
Flags: review?(rexboy)
Assignee | ||
Updated•11 years ago
|
Whiteboard: [NO_UPLIFT]
Assignee | ||
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 6•11 years ago
|
||
This bug has landed on master but not on v1.1.0hd. What happened?
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
status-b2g18:
--- → affected
Resolution: --- → FIXED
Reporter | ||
Updated•11 years ago
|
status-b2g18:
affected → ---
status-b2g-v1.1hd:
--- → affected
Reporter | ||
Comment 7•11 years ago
|
||
I should leave this open ...
Reporter | ||
Updated•11 years ago
|
status-firefox25:
--- → fixed
Assignee | ||
Comment 8•11 years ago
|
||
Hi James, There are two patches for supporting hdpi resolution device. This patch is specifically for v1.1.0hd branch. And the PR https://github.com/mozilla-b2g/gaia/pull/10743 is for mater branch. Please help me review the patch. Thanks. :)
Attachment #770816 -
Flags: review?(jlal)
Assignee | ||
Updated•11 years ago
|
Attachment #770816 -
Flags: review?(rexboy)
Assignee | ||
Updated•11 years ago
|
Attachment #770094 -
Attachment description: Point to the GitHub pull request: https://github.com/mozilla-b2g/gaia/pull/10743 → The PR is for master
Assignee | ||
Updated•11 years ago
|
Attachment #770816 -
Attachment description: Point to GitHub pull request: https://github.com/mozilla-b2g/gaia/pull/10768 → The PR is for v1.1.0hd
Updated•11 years ago
|
Attachment #770094 -
Flags: review?(rexboy)
Comment 9•11 years ago
|
||
Comment on attachment 770816 [details]
The PR is for v1.1.0hd
Some comments on Github.
Please set review to me again once you finished it. Thank you!
Attachment #770816 -
Flags: review?(rexboy)
Assignee | ||
Comment 10•11 years ago
|
||
Comment on attachment 770816 [details]
The PR is for v1.1.0hd
Hi Rex,
I already updated for your comments in GitHub.
Please help me review patch.
Thanks. :)
Attachment #770816 -
Flags: review?(rexboy)
Assignee | ||
Comment 11•11 years ago
|
||
Hi Rex, I already updated the images. Please help me review the patch. Thanks. :)
Attachment #771561 -
Flags: review?(rexboy)
Comment 12•11 years ago
|
||
Comment on attachment 770816 [details]
The PR is for v1.1.0hd
Most of them seems good to me but I found a few layout breaking. See Github comments.
Please fix them and I'll r+ your patch. Thanks a lot!
Assignee | ||
Comment 13•11 years ago
|
||
Hi Rex, I already updated the PR for your comments. And could you please help me review the PR in https://github.com/mozilla-b2g/gaia/pull/10805. Thanks. :)
Comment 14•11 years ago
|
||
Comment on attachment 771561 [details]
The PR is for updating images in master branch
r=me
Thanks for updating this!
Attachment #771561 -
Flags: review?(rexboy) → review+
Comment 15•11 years ago
|
||
Comment on attachment 770816 [details]
The PR is for v1.1.0hd
See comments on Github. we can land this after you solve the white padding for dayView .
Thanks a lot!
Attachment #770816 -
Flags: review?(rexboy)
Reporter | ||
Comment 16•11 years ago
|
||
(In reply to KM Lee [:rexboy] from comment #15) > Comment on attachment 770816 [details] > The PR is for v1.1.0hd > > See comments on Github. we can land this after you solve the white padding > for dayView . > Thanks a lot! Evan, what stopped this from being landed?
Flags: needinfo?(evanxd)
Assignee | ||
Comment 17•11 years ago
|
||
Hi Tim, Sorry, I had no time to update the code for comments. We had meeting whole day for Scrum planning meeting. Ian and I just finished the discussion about Scrum planning meeting. I would like to continue to code for comments now. I think I could update the code for review later.
Flags: needinfo?(evanxd)
Assignee | ||
Comment 18•11 years ago
|
||
Comment on attachment 770816 [details] The PR is for v1.1.0hd Hi Rex, I already updated the code for your comments. And I also fixed the while space in master branch with PR https://github.com/mozilla-b2g/gaia/pull/10805/files#L2R162. Please help me review the patch. Thanks. :)
Attachment #770816 -
Flags: review?(rexboy)
Comment 19•11 years ago
|
||
Comment on attachment 770816 [details]
The PR is for v1.1.0hd
Looks perfect to me.
Thanks for your work!
Attachment #770816 -
Flags: review?(rexboy) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #770816 -
Flags: review?(jlal)
Assignee | ||
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 20•11 years ago
|
||
v1.1hd: https://github.com/mozilla-b2g/gaia/commit/1c42134a3d06501650b7d3a46c7eafd6dc9d26af master (2nd parch): https://github.com/mozilla-b2g/gaia/commit/d31a5b25a436547d27b5f99e8a163d16d906ce61
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•