Matias Crivolotti Assignee
	Description • 11 years ago

localStorage is blocky.
Loading E.me freezes when there is a lot of data stored.

Need to convert to IndexedDB

	Cristian Rodriguez (:crdlc)
	Comment 2 • 11 years ago

Comment on attachment 754220 [details]
redirect to PR 10004

Good work!!

	Ran Ben Aharon [:ranbena] EverythingMe
	Comment 3 • 11 years ago

Merged in into master https://github.com/mozilla-b2g/gaia/commit/d54a6e1e78f73e7c7b030512046547933fb8dec9

	Evyatar 'Tron' Amitay (everything.me)
	Comment 4 • 11 years ago

thanks for the review Cristian, we always feel bad when sending you a huge PR to review :) hopefully this will help with performance!

	Cristian Rodriguez (:crdlc)
	Comment 5 • 11 years ago

don't worry my friend!

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 11 years ago

(In reply to Ran Ben Aharon (Everything.me) from comment #3)
> Merged in into master
> https://github.com/mozilla-b2g/gaia/commit/
> d54a6e1e78f73e7c7b030512046547933fb8dec9

John, can you assist with the uplift please?

	John Ford [:jhford] CET/CEST Berlin Time
	Comment 7 • 11 years ago

I guess this doesn't really need checkin anymore, but it does have a pretty large conflict on the v1-train branch!

	Ran Ben Aharon [:ranbena] EverythingMe
	Comment 8 • 11 years ago

Conflict resolved and pushed to v1-train
https://github.com/mozilla-b2g/gaia/commit/e2346ca0297f40547e64a7eebc4bd2e4a4cdaf86

	Tony Chung [:tchung]
	Comment 10 • 11 years ago

 (In reply to matias from comment #0)
> localStorage is blocky.
> Loading E.me freezes when there is a lot of data stored.
> 
> Need to convert to IndexedDB

how to verify this fix?  what's the definition of "blocky" and "lot of data" stored?  STR would help.

	Evyatar 'Tron' Amitay (everything.me)
	Comment 11 • 11 years ago

STR:
1. Reset the device and load e.me
2. The progress should fill rather quickly and load e.me
3. Perform a lot of searches- open smart folders, perform query searches
4. Restart the device
5. Load e.me again- at this point you should see a noticeable stutter at around 70% of the progress (this is because we cached data in a synchronous fashion)

With this patch applied the loading of e.me shouldn't get stuck, no matter how much data is stored.

	sbogati
	Comment 12 • 11 years ago

Issue does not repro, on Leo device.
Build ID: 20130807071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/11bb1b0eefff
Gaia: 60ca81600a080dae33058b0692ecaa213556c926
Platform Version: 18.1
E.com loading as expected.