Ian Barlow (:ibarlow) Reporter
	Description • 11 years ago

The current number+arrow doesn't work very well with the new single colour tab design. This new icon does a better job at communicating what the number is associated with. 

It also simplifies our lives since we no longer have the "which way does the arrow need to point" problem. 

The number inside the icon should be Roboto Bold, 12sp, #43484e, and should be kerned a little tighter than normal if possible.

	Ian Barlow (:ibarlow) Reporter
	Comment 1 • 11 years ago

Oh, this is what it should look like btw http://cl.ly/image/2u123j1W130m

	Aaron Train [:aaronmt]
	Comment 2 • 11 years ago

^. That is lovely.

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 3 • 11 years ago

(In reply to Aaron Train [:aaronmt] from comment #2)
> ^. That is lovely.

agreed

	Sriram Ramasubramanian [:sriram] Assignee
	Comment 4 • 11 years ago

Oooooh. So pretty icon!
Note: This patch doesn't fix the landscape files as we are filling them in bug 861138

	Sriram Ramasubramanian [:sriram] Assignee
	Comment 5 • 11 years ago

This adds a heart beat like animation. Old value shrinks to 80%, and new value expands from 80% to 100%.

	Ian Barlow (:ibarlow) Reporter
	Comment 6 • 11 years ago

Let's land this asap and try to uplift it with the rest of the new 1-colour tab button work. 

I filed bug 863828 to finish up the tab increment transition that should accompany it.

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 7 • 11 years ago

Comment on attachment 739306 [details] [diff] [review]
Patch

I saw an early screenshot of this patch in action. The number seemed to be overlayed a bit "high" in the image. Please verify that the number is positioned nicely.

	Ian Barlow (:ibarlow) Reporter
	Comment 8 • 11 years ago

Screenshot?

	Lucas Rocha (:lucasr)
	Comment 9 • 11 years ago

FYI: I rebases sriram's patch to account for the toolbar changes done in bug 858687. I'll wait until the patches for bug 858687 land in m-c before pushing it just to avoid a potential backout-fest.

	Lucas Rocha (:lucasr)
	Comment 10 • 11 years ago

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/9df37c60263f

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/9df37c60263f

	Hervé Renault
	Comment 12 • 11 years ago

I'm sorry for being late but I find this new count too small to read (for my eyes, at least). I just filed a bug yesterday to complain about that : https://bugzilla.mozilla.org/show_bug.cgi?id=868538