Mark Finkle (:mfinkle) (use needinfo?) Assignee
	Description • 11 years ago

The awesomescreen will load favicons in a separate, lazy task. However the Cursor holding the favicons is handed back to the UI thread where we loop over the data, decode bitmaps and store in the Favicon mem cache.

We should be doing that in the background thread. This patch moves the function call to the background thread.

	Mark Finkle (:mfinkle) (use needinfo?) Assignee
	Comment 1 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/5549afae23a7

	Ryan VanderMeulen [:RyanVM]
	Comment 2 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/5549afae23a7

	Mark Finkle (:mfinkle) (use needinfo?) Assignee
	Comment 3 • 11 years ago

Comment on attachment 734729 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: DB code on the UI thread can cause ANR hangs and locks. Plus we are decoding bitmaps on the UI thread instead of the background thread.
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low risk. straight forward change
String or IDL/UUID changes made by this patch: none

	bhavana bajaj [:bajaj]
	Comment 4 • 11 years ago

Comment on attachment 734729 [details] [diff] [review]
patch

low risk patch with stability win. Approving for beta/aurora .

	Mark Finkle (:mfinkle) (use needinfo?) Assignee
	Comment 5 • 11 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/ed74f240c19f
https://hg.mozilla.org/releases/mozilla-beta/rev/565c52f0f8c3

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 6 • 11 years ago

Comment on attachment 734729 [details] [diff] [review]
patch

[Triage Comment]
We're going to take this low risk, stability win for our 20.0.1 mobile respin

	Mark Finkle (:mfinkle) (use needinfo?) Assignee
	Comment 7 • 11 years ago

https://hg.mozilla.org/releases/mozilla-release/rev/bbcdbe0556cf