Victor Porof [:vporof][:vp] Assignee
	Description • 11 years ago

      No description provided.

	Victor Porof [:vporof][:vp] Assignee
	Comment 1 • 11 years ago

Moving into Developer Tools: Netmonitor component. Filter on NETMONITORAMA.

	David Creswick
	Comment 2 • 11 years ago

How would this be reconciled with the tooltip text that pops up when one hovers over the various cells of the request line? You wouldn't want them to overlap, and that might be very hard to guarantee on all platforms. I guess on some platforms, you can put images in tooltips too, but is that possible on all platforms? It doesn't really make sense to show the image in every tooltip of every cell when every tooltip has different textual information. On the other hand, if it's only shown in the tooltip of one of the cells, that makes it harder for users to discover its existence.

	Victor Porof [:vporof][:vp] Assignee
	Comment 3 • 11 years ago

I think this is reasonable and a huge timesaver for people who developed such muscle memory. Implementation is easy and cross platform if done in XUL (although xul:panels are quite buggy). My suggestion is having this panel shown when hovering every request in the menu (but not when hovering the waterfall section).

Rob, what do you think about this?

	Rob Campbell [:rc] (:robcee)
	Comment 4 • 11 years ago

(In reply to Victor Porof [:vp] from comment #3)
> I think this is reasonable and a huge timesaver for people who developed
> such muscle memory. Implementation is easy and cross platform if done in XUL
> (although xul:panels are quite buggy). My suggestion is having this panel
> shown when hovering every request in the menu (but not when hovering the
> waterfall section).
> 
> Rob, what do you think about this?

Totally do-able. Not sure what you mean by "hovering every request in the menu" though. The text columns in the table but not the graphical waterfall? If so, I say go for it.

	Victor Porof [:vporof][:vp] Assignee
	Comment 5 • 11 years ago

(In reply to Rob Campbell [:rc] (:robcee) from comment #4)
> 
> Totally do-able. Not sure what you mean by "hovering every request in the
> menu" though. The text columns in the table but not the graphical waterfall?

Yup!

> If so, I say go for it.

!

	Rubén Martín [:Nukeador] ❌ [away till Aug 31st]
	Comment 6 • 11 years ago

Related to #765105 ?

	Victor Porof [:vporof][:vp] Assignee
	Comment 7 • 11 years ago

Sure.

	Greg Karz
	Comment 8 • 11 years ago

I think #874884 should be fixed before this. Maybe depends on? Or is it not such a priority?

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]
	Comment 9 • 11 years ago

(In reply to Greg Karz from comment #8)
> I think #874884 should be fixed before this. Maybe depends on? Or is it not
> such a priority?

It seems to me that neither bug needs to block work on the other.

	Victor Porof [:vporof][:vp] Assignee
	Comment 10 • 11 years ago

I'd love it if bug 765105 offered us a reusable component or widget. I agree it's not entirely related to bug 874884.

	Victor Porof [:vporof][:vp] Assignee
	Comment 11 • 10 years ago

Patrick, please have a quick glance over the changes in Tooltip.js. Thanks!

	Patrick Brosset <:pbro>
	Comment 12 • 10 years ago

Comment on attachment 8375525 [details] [diff] [review]
v1 wip

Review of attachment 8375525 [details] [diff] [review]:
-----------------------------------------------------------------

I've been meaning to do this recently but since I didn't have an immediate use for it, I didn't
+1 for this!

	Victor Porof [:vporof][:vp] Assignee
	Comment 14 • 10 years ago

Found a bug where tooltips wouldn't be shown if the contents of the requests table would be sorted or filtered after a navigation. Fixed, added more assertions in tests.

	Victor Porof [:vporof][:vp] Assignee
	Comment 15 • 10 years ago

Try is green: https://tbpl.mozilla.org/?tree=Try&rev=fe034c24c583

	Victor Porof [:vporof][:vp] Assignee
	Comment 16 • 10 years ago

https://hg.mozilla.org/integration/fx-team/rev/55252570e8d6

	:Gijs (he/him)
	Comment 17 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/55252570e8d6

	Andrei Vaida [:avaida]
	Comment 18 • 10 years ago

I was able to confirm the fix for this issue on Firefox 30 Beta 3 (Build ID: 20140508121358), using:
  * Windows 7 64-bit [1],
  * Ubuntu 12.04 32-bit [2],
  * Mac OS X 10.8.5 [3].

[1] Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
[2] Mozilla/5.0 (X11; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0
[3] Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:30.0) Gecko/20100101 Firefox/30.0