Closed Bug 817775 Opened 12 years ago Closed 12 years ago

Marketplace promo is active on beta on about:home, but it shouldn't be

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox18 verified, firefox19 verified, firefox20+ verified, firefox21+ verified, firefox22 affected, firefox23 affected)

VERIFIED FIXED
Tracking Status
firefox18 --- verified
firefox19 --- verified
firefox20 + verified
firefox21 + verified
firefox22 --- affected
firefox23 --- affected

People

(Reporter: jsmith, Assigned: mfinkle)

Details

Attachments

(1 file)

Apparently the marketplace promo is showing up Beta 1 for FF Android on 18. Although we're not supposed to be showing it, right?
tracking-fennec: --- → ?
Component: Web Apps → General
QA Contact: aaron.train
Since this changes every other month, I think let it ride the trains; 18 is done.
(In reply to Aaron Train [:aaronmt] from comment #1)
> Since this changes every other month, I think let it ride the trains; 18 is
> done.

This isn't a nightly and aurora issue - it's a beta or release issue. Riding the trains isn't going to solve this problem.
Personally, I am fine with showing it. The Marketplace currently has a banner to direct people to use Firefox Beta for Android, why not return the favor? What are the downsides to removing it?
(In reply to Mark Finkle (:mfinkle) from comment #3)
> Personally, I am fine with showing it. The Marketplace currently has a
> banner to direct people to use Firefox Beta for Android, why not return the
> favor? What are the downsides to removing it?

Fair point. I don't have any issues personally with showing it. I just thought marketing was against this.

Which comes the point when I cc Dan for input.
Flags: needinfo?(dhorner)
The Marketplace should not have a banner telling people to use Firefox Beta for Android.

It should have a banner telling people to use Firefox_Aurora_for Android.

-d
Flags: needinfo?(dhorner)
(In reply to Dan Horner from comment #5)
> The Marketplace should not have a banner telling people to use Firefox Beta
> for Android.
> 
> It should have a banner telling people to use Firefox_Aurora_for Android.
> 
> -d

Why is that? I talked to Mark Finkle about it and he seemed fine to channel people towards beta. It makes more sense to encourage people to use Beta which is more stable compared to Aurora.

However, if there is a reason we shouldn't be doing this we can revert to showing banners about Aurora again.
The Marketplace is not of Beta quality yet - hence we're not promoting it to a Beta audience yet.

Beta is scheduled for launch some time in the beginning of the year; the exact criteria for this launch are still being agreed upon by Rick, BD and Marketing.
Attached patch patchSplinter Review
Brad - This is the same patch you reviewed a few weeks ago to remove the Apps promo from Firefox Beta. I missed adding this to the list of things that should be removed from Beta after a merge. I am re-asking for review since the menu XML required a change.
Assignee: nobody → mark.finkle
Attachment #688067 - Flags: review?(blassey.bugs)
Attachment #688067 - Flags: approval-mozilla-beta?
Attachment #688067 - Flags: review?(blassey.bugs) → review+
Comment on attachment 688067 [details] [diff] [review]
patch

Please land today to make it into beta 3.
Attachment #688067 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/8de8954a383c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verifying (mozilla-beta, 18.0 Beta 3)
 ... (-) no app menu
 ... (-) no promo on about:home
Status: RESOLVED → VERIFIED
Firefox 19 Beta 1 (2013-01-08)
Device: Galaxy Nexus
OS:Android 4.1.

Verified Fixed in Firefox 19 Beta 1 (no promo and no apps in the menu ).
Let's get this out of all shipping code for now until MP is ready to be added in.
Comment on attachment 688067 [details] [diff] [review]
patch

[Triage Comment]
Please land this to branches release thru aurora so we can remove it from shipping builds.
Attachment #688067 - Flags: approval-mozilla-release+
Attachment #688067 - Flags: approval-mozilla-aurora+
Bug 859994 will handle removing from aurora and trunk
Verified on Firefox for Android 21.0b6 using: Nexus 4 (4.2.2)
tracking-fennec: ? → ---
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: