Eric Chou [:ericchou] [:echou] Assignee
	Description • 12 years ago

With today's (11/8) latest Gecko & Gaia, we tried to send file by pressing "Send to Bluetooth Device" button on Gallery's share menu but failed. According to the message, onerror() of the returned DOMRequest was invoked after calling function nsIDOMBluetoothAdapter.Connect().

	Kai-Chih Hu [:khu]
	Comment 1 • 12 years ago

Should be bb+.

	Eric Chou [:ericchou] [:echou] Assignee
	Comment 2 • 12 years ago

* Fixed the sending file failure issue.
* Now we'll send Disconnect request when receiving unexpected response from remote.
* Remove the null character at the end of 'Name' header

	Gina Yeh [:gyeh] [:ginayeh]
	Comment 3 • 12 years ago

Comment on attachment 680990 [details] [diff] [review]
patch 1: v1: fixed sending file failure and added erorr handling

Review of attachment 680990 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nit addressed.

::: dom/bluetooth/BluetoothOppManager.cpp
@@ +1086,5 @@
>  BluetoothOppManager::OnConnectError()
>  {
> +  if (mRunnable) {
> +    nsString errorStr;
> +    errorStr.AssignLiteral("Failed to connect with a bluetooth headset!");

Shouldn't be a bluetooth headset!

	Eric Chou [:ericchou] [:echou] Assignee
	Comment 4 • 12 years ago

* nit picked

	Eric Chou [:ericchou] [:echou] Assignee
	Comment 5 • 12 years ago

try:

https://tbpl.mozilla.org/?tree=Try&rev=dc1aeac43f3c
https://tbpl.mozilla.org/?tree=Try&rev=8db6668ec9d9

	Eric Chou [:ericchou] [:echou] Assignee
	Comment 6 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/51fa971d2280

	Ed Morley [:emorley]
	Comment 7 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/51fa971d2280

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 12 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/ee1af9505593