iliu@mozilla.com, ianliu.moz@gmail.com Assignee
	Description • 12 years ago

Need to check SDCard status:
1. Exist or not
2. Mounted or not
3. Free space available or not

	iliu@mozilla.com, ianliu.moz@gmail.com Assignee
	Comment 1 • 12 years ago

I think it should be blocking-basecamp + .

	Mike Connor [:mconnor]
	Comment 2 • 12 years ago

Part of making a required feature work correctly -> P1.

	iliu@mozilla.com, ianliu.moz@gmail.com Assignee
	Comment 3 • 12 years ago

Pointer to Github pull-request

	David Flanagan [:djf]
	Comment 4 • 12 years ago

Comment on attachment 679196 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6247

See comments on github. I think you can simplify your code quite a bit. But the two reasons you get r- here are:

1) there is an unnecessary extra call to stat() 

2) I think you should check for available space before asking the user to accept the transfer.

	Alex Keybl [:akeybl]
	Comment 5 • 12 years ago

We're marking this bug with the C1 milestone since it follows the criteria of "unfinished feature work" (see https://etherpad.mozilla.org/b2g-convergence-schedule).

If this work is not finished by Nov19, this bug will need an exception and will be called out at the upcoming Exec Review.

	iliu@mozilla.com, ianliu.moz@gmail.com Assignee
	Comment 6 • 12 years ago

(In reply to David Flanagan [:djf] from comment #4)
> Comment on attachment 679196 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6247
> 
> See comments on github. I think you can simplify your code quite a bit. But
> the two reasons you get r- here are:
> 
> 1) there is an unnecessary extra call to stat() 
> 
> 2) I think you should check for available space before asking the user to
> accept the transfer.

Hi David,
I have refined above comments in the latest patch.
Could you help to review my patch?
Thank you.

	David Flanagan [:djf]
	Comment 7 • 12 years ago

Comment on attachment 679196 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6247

I had quite a few comments on the code in github. They are code clarity issues, mostly. If you have the time, I think you can still improve the code, but r+ to land because I suspect you want this to work in time for the demo.

	Dominic Kuo [:dkuo]
	Comment 8 • 12 years ago

David,

Eric and I have discussed yesterday and we decided to demo receiving files via bluetooth, but without opening the received file because Ian's PR was reviewing and he is in Taipei, so I think it will be better for Ian to improve the code more, especially some typo or simple case handling. Also we have a problem about deviceStorage that uses "sdcard", I will help Ian to figure out how to use deviceStorage correctly after I am back to Taipei, so I am giving a r- first before this patch improves.

	iliu@mozilla.com, ianliu.moz@gmail.com Assignee
	Comment 9 • 12 years ago

Comment on attachment 679196 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6247

According David's comment and previous discussion, I have refined the patch.
Could Dominic help to review my patch?
Thank you.

	iliu@mozilla.com, ianliu.moz@gmail.com Assignee
	Comment 10 • 12 years ago

(In reply to Ian Liu [:ianliu] from comment #9)
> Comment on attachment 679196 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6247
> 
For the patch, Bluetooth APP will do the error handle to check SDCard status before receiving file by other devices. 
In side of platform, Bluetooth API will do the same error handle too.
Note to QA: In general case, we could not reproduce the issue.

> According David's comment and previous discussion, I have refined the patch.
> Could Dominic help to review my patch?
> Thank you.

	Dominic Kuo [:dkuo]
	Comment 11 • 12 years ago

Comment on attachment 679196 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6247

r+, and please see github comments.

	iliu@mozilla.com, ianliu.moz@gmail.com Assignee
	Comment 12 • 12 years ago

(In reply to Ian Liu [:ianliu] from comment #10)
> (In reply to Ian Liu [:ianliu] from comment #9)
> > Comment on attachment 679196 [details]
> > Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6247
> > 
> For the patch, Bluetooth APP will do the error handle to check SDCard status
> before receiving file by other devices. 
> In side of platform, Bluetooth API will do the same error handle too.
> Note to QA: In general case, we could not reproduce the issue.
> 
Please reference the issue link: https://bugzilla.mozilla.org/show_bug.cgi?id=809538
> > According David's comment and previous discussion, I have refined the patch.
> > Could Dominic help to review my patch?
> > Thank you.

	iliu@mozilla.com, ianliu.moz@gmail.com Assignee
	Comment 13 • 12 years ago

Since the pr https://github.com/mozilla-b2g/gaia/pull/6247 is merged, we can close the issue.

	mlevin
	Comment 14 • 11 years ago

Works fine on Unagi build 20130103070201

	mlevin
	Comment 15 • 11 years ago

Works fine on Unagi build 20130103070201.
See screen shot attachment.