Closed
Bug 792253
Opened 12 years ago
Closed 12 years ago
Share menu items should be displayed in custom menu
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox18 verified)
VERIFIED
FIXED
Firefox 18
Tracking | Status | |
---|---|---|
firefox18 | --- | verified |
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(2 files, 1 obsolete file)
11.34 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora-
|
Details | Diff | Splinter Review |
2.43 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora-
|
Details | Diff | Splinter Review |
Share menu items are displayed in an ActivityChooser given by Android. 1. It's start a new activity -- which puts ours into onPause(). 2. It doesn't follow our theme. It's better to show the list in our custom menu.
Assignee | ||
Comment 1•12 years ago
|
||
This patch show the share menu items in our custom list. This is enabled only for 11+, as we support custom menu only there. Gingerbread phones show the activity chooser. There is a bit of cleanup. I felt a menu item listener needn't do "closeOptionsMenu()". So, the menu item will pass on the event to parent Menu, which will do the necessary cleanups. The Menu will call the listener directly in this case.
Attachment #662327 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 2•12 years ago
|
||
The previous patch missed an animation. It's now added.
Attachment #662327 -
Attachment is obsolete: true
Attachment #662327 -
Flags: review?(mark.finkle)
Attachment #662362 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 3•12 years ago
|
||
This patch (tries to) sorts the list based on the preferredOrder. I don't know how that works. Probably android keeps a history of sharing, and increases the count or something. But my initial test gave 0 for all entries. We could try having it and see if order changes over time.
Attachment #662363 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #662362 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
Attachment #662363 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/2c3416b05490 https://hg.mozilla.org/integration/mozilla-inbound/rev/d71ef24d5b56
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2c3416b05490 https://hg.mozilla.org/mozilla-central/rev/d71ef24d5b56
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 662362 [details] [diff] [review] Patch (1/2): Share [Approval Request Comment] Bug caused by (feature/regressing bug #): New feature User impact if declined: Share will be same old activity, and wouldnt be a part of submenu. Testing completed (on m-c, etc.): Landed on m-c on 09/19 Risk to taking this patch (and alternatives if risky): None. String or UUID changes made by this patch: None.
Attachment #662362 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 662363 [details] [diff] [review] Patch (2/2): Sort [Approval Request Comment] Bug caused by (feature/regressing bug #): New feature. User impact if declined: Share list (may be) sorted. Testing completed (on m-c, etc.): Landed on m-c on 09/19 Risk to taking this patch (and alternatives if risky): None. String or UUID changes made by this patch: None.
Attachment #662363 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Assignee: nobody → sriram
Comment 8•12 years ago
|
||
Comment on attachment 662362 [details] [diff] [review] Patch (1/2): Share [Triage Comment] This would need to be a product request for uplift, since it could cause a regression (we're skeptical of the risk evaluation here).
Attachment #662362 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Updated•12 years ago
|
Attachment #662363 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Comment 9•12 years ago
|
||
Product is requesting uplift for 17, please.
Comment 10•12 years ago
|
||
Share option was added in custom menu for the latest Nightly. Closing bug as verified fixed on: Firefox 18.0a1 (2012-09-24) Device: Galaxy Note OS: Android 4.0.4
Status: RESOLVED → VERIFIED
status-firefox18:
--- → verified
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•