Alice0775 White Reporter
	Description • 12 years ago

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/8c85c83068e7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120819030601

"Reddit Enhancement Suite" stops working

Step To Reproduce:
1. Install "Reddit Enhancement Suite" extensions http://redditenhancementsuite.com/download-firefox.html
2. Open http://www.reddit.com/r/funny/ (for example)
3. Scroll down (for example)

Actual Results:
  Auto-pager does not work

Expected Results:
  Auto-pager should work

	Bobby Holley (:bholley)
	Comment 1 • 12 years ago

They almost certainly need to add __exposedProps__ somewhere. CCing jorge.

	Andreas Gal :gal
	Comment 2 • 12 years ago

We already know about 2 broken add-ons. There are likely many more. We might need to back off here and evangelize before we reland the patch.

	Bobby Holley (:bholley)
	Comment 3 • 12 years ago

(In reply to Andreas Gal :gal from comment #2)
> We already know about 2 broken add-ons. There are likely many more. We might
> need to back off here and evangelize before we reland the patch.

I disagree. We nixed the landing of this patch 2 releases ago for exactly that purpose (we also added warnings in the developer console).

Fixing all the in-tree consumers that landed without __exposedProps__ in the last two months consumed almost a week of my time. Unless there are resources to make sure this stuff actually happens, flipping the switch is the only way to do this. And we very much need to do it for security reasons.

	Andrew McCreight [:mccr8]
	Comment 4 • 12 years ago

You could also let it bubble downstream a bit, and turn it off in Aurora or Beta. That would at least prevent m-c breakage.  Of course, if you want to do that, you should add back the NoExposedPropsWarning string right now so its re-addition doesn't freak out localizers.

	Gian-Carlo Pascutto [:gcp]
	Comment 5 • 12 years ago

Bugzilla Tweaks also broke.

	Andrew McCreight [:mccr8]
	Comment 6 • 12 years ago

(In reply to Gian-Carlo Pascutto (:gcp) from comment #5)
> Bugzilla Tweaks also broke.

Please file a new Tech Evangelism - Addons bug on Bugzilla Tweaks.  Thanks.

	Andreas Gal :gal
	Comment 7 • 12 years ago

bholley, I feel your pain, but you have caused massive extension breakage with this patch. Burying your head in the sand won't help here. I agree with keeping the patch alive for in-browser code so we don't regress there. Can we distinguish between wrappers being created from within our jar and extension code until we had time to move extensions over?

	Jorge Villalobos [:jorgev] (he/him)
	Comment 8 • 12 years ago

CCing RES developer.

(In reply to Andreas Gal :gal from comment #7)
> bholley, I feel your pain, but you have caused massive extension breakage
> with this patch. Burying your head in the sand won't help here. I agree with
> keeping the patch alive for in-browser code so we don't regress there. Can
> we distinguish between wrappers being created from within our jar and
> extension code until we had time to move extensions over?

I think this discussion belongs in bug 553102.

	Bobby Holley (:bholley)
	Comment 9 • 12 years ago

(In reply to Andreas Gal :gal from comment #7)

Replied in bug 553102 comment 116.

	Gian-Carlo Pascutto [:gcp]
	Comment 10 • 12 years ago

This appears to be fixed (or given the warnings in Error Console, worked around).

	Jorge Villalobos [:jorgev] (he/him)
	Comment 11 • 12 years ago

Closing based on comment #10.