Aaron Train [:aaronmt] Reporter
	Description • 12 years ago

Firefox Beta 11.0 (XUL) is not displayed (compatable) with tablets on the Android Market, thus no update and no product shown.

	Alex Keybl [:akeybl]
	Comment 1 • 12 years ago

We'll want to fix this for beta 4. No need to re-spin beta 3 though, since the update just isn't offered to tablet users currently (no errors, etc.). Also, XUL 11 will not be shipped to release (10.0.3 will), so no issue there.

	Aaron Train [:aaronmt] Reporter
	Comment 2 • 12 years ago

Looks to be the SMS permission causing an issue.

Phone users will see permissions:

Services that cost you money: 
Send SMS messages

Your messages: 
Receive SMS

	Mounir Lamouri (:mounir) Assignee
	Comment 4 • 12 years ago

Comment on attachment 598373 [details] [diff] [review]
Remove SMS permissions

[Approval Request Comment]
User impact if declined: no Firefox Beta for tablets in the Android Market
Testing completed (on m-c, etc.): this permission is already disabled in m-c
Risk to taking this patch (and alternatives if risky): contents using WebSMS will break but we can safely assume that those contents do not exist because nor Aurora or Nightly have WebSMS enabled by default (Firefox neither)

	Tony Chung [:tchung]
	Comment 5 • 12 years ago

aki, please ping QA if we want this re-tested with a practice build first, on Android Market.

	Aki Sasaki (not active)
	Comment 6 • 12 years ago

(In reply to Tony Chung [:tchung] from comment #5)
> aki, please ping QA if we want this re-tested with a practice build first,
> on Android Market.

I think we do want this re-tested with a practice build.
I'm currently waiting for that build; I can put it in the test Android Market account, and QA can re-test after that point.

	Mounir Lamouri (:mounir) Assignee
	Comment 7 • 12 years ago

https://hg.mozilla.org/releases/mozilla-beta/rev/6df75f4d5ccc

Can the QA test the build generated by the build bots?

	Kevin Brosnan [Ex-Mozilla]
	Comment 8 • 12 years ago

Where is the build?

	Aki Sasaki (not active)
	Comment 9 • 12 years ago

(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #7)
> https://hg.mozilla.org/releases/mozilla-beta/rev/6df75f4d5ccc
> 
> Can the QA test the build generated by the build bots?

No, they can't.
We need a build with a different app name to put on the market.

	Brad Lassey [:blassey] (use needinfo?)
	Comment 10 • 12 years ago

I pushed tip of beta to try with a package name change:
https://tbpl.mozilla.org/?tree=Try&rev=c4e8bdb49682
builds will be here:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/blassey@mozilla.com-c4e8bdb49682

	Aaron Train [:aaronmt] Reporter
	Comment 11 • 12 years ago

Drop a comment here with the market package name or email me and I'll give it a test tonight/tomorrow.

	Aki Sasaki (not active)
	Comment 12 • 12 years ago

(In reply to Brad Lassey [:blassey] from comment #10)
> I pushed tip of beta to try with a package name change:
> https://tbpl.mozilla.org/?tree=Try&rev=c4e8bdb49682
> builds will be here:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/blassey@mozilla.
> com-c4e8bdb49682

The package name of your apk (org.mozilla.firefox_beta) is the same as the package name of another developer's application. Choose a new package name.

	Aki Sasaki (not active)
	Comment 13 • 12 years ago

Giving it another shot:

https://tbpl.mozilla.org/?tree=Try&rev=f6132bf40115
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/asasaki@mozilla.com-f6132bf40115

	Brad Lassey [:blassey] (use needinfo?)
	Comment 14 • 12 years ago

I expected try to build with nightly branding, not beta.

Just to be safe I also pushed another, with the package name of every branding changed to org.mozilla.fennec_sms_test:
https://tbpl.mozilla.org/?tree=Try&rev=1d475a4290de

	Mounir Lamouri (:mounir) Assignee
	Comment 15 • 12 years ago

(In reply to Aki Sasaki [:aki] from comment #9)
> No, they can't.
> We need a build with a different app name to put on the market.

Sorry about that. And thank you Brad for providing a build.

	Aki Sasaki (not active)
	Comment 16 • 12 years ago

I uploaded 'smstest' to the market.
It looks good, but I haven't tried installing it on a tablet yet.

	Aki Sasaki (not active)
	Comment 17 • 12 years ago

(In reply to Brad Lassey [:blassey] from comment #14)
> I expected try to build with nightly branding, not beta.

Try builds with the in-tree mozconfig, e.g.
https://hg.mozilla.org/try/file/1d475a4290de/mobile/xul/config/mozconfigs/android/nightly

Since we're pushing from beta, that points to beta branding.
The Try talos/unit tests assume nightly branding, which is why this breaks.
Once bug 725703 is fixed that won't be the case anymore, but we might not have an early warning system that we merged branding incorrectly (e.g. beta will start building with aurora branding and tests will be green).

	Aaron Train [:aaronmt] Reporter
	Comment 18 • 12 years ago

verified fixed via Galaxy Tab 10.1, and a Galaxy Nexus using market package posted above

	Tony Chung [:tchung]
	Comment 19 • 12 years ago

i got firefox 11.0 XUL on both SGS2 and Galaxy Nexus.   I dont have any tablets on me at the moment.

	Aki Sasaki (not active)
	Comment 20 • 12 years ago

Thanks!
When you're done testing, I should take this down.  Is there more testing planned?

	Ioana Chiorean
	Comment 21 • 12 years ago

Verified on 
Tablets:
Asus Eee Transformers - Android 3.2
Asus Eee Transformers - Android 3.1
Galaxy Tab 10.1 - Android 3.1 
Phones:
Samsung Galaxy Nexus - android 4.0.2
Samsung Nexus S - Android 2.3.6

	Aaron Train [:aaronmt] Reporter
	Comment 22 • 12 years ago

@aki, remove it

	Aki Sasaki (not active)
	Comment 23 • 12 years ago

Awesome, done.