Closed
Bug 719276
Opened 12 years ago
Closed 3 years ago
Double tapping causes css :active to remain
Categories
(Firefox for Android Graveyard :: General, defect, P5)
Tracking
(firefox16 affected, firefox17 affected, firefox18 affected, blocking-fennec1.0 -, fennec+)
People
(Reporter: martijn.martijn, Unassigned)
References
Details
(Keywords: testcase, Whiteboard: [lang=js])
Attachments
(3 files)
400 bytes,
text/html
|
Details | |
4.58 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
843 bytes,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
See testcase. When double tapping on one of the elements, the link, the text input or the div, the background color remains, which is from the css :active rule they have. In XUL Fennec, the background color is only visible for a short while, as if tapped. In the Android stock browser, no background color is shown at all when double tapping. It seems to me that is the correct behavior. Tested on the LG Optimus Black, Android 2.2.2.
Updated•12 years ago
|
tracking-fennec: --- → +
Comment 1•12 years ago
|
||
wes, i don't think this is a beta or final blocker. But over to you for investigation post 1.0
Assignee: nobody → wjohnston
Priority: -- → P3
Comment 2•12 years ago
|
||
I'm throwing everything at you today matt. I'm not exactly happy with this solution, but its an ok bandaid I think. The issue is with the Java system Gesture detectors we're using. Essentially, they send me: Gesture:ShowPress Gesture:DoubleTap Gesture:ShowPress Any time we start changing the viewport, I think we probably want to remove tapHighlight, so that's what the patch basically does.
Attachment #602433 -
Flags: review?(mbrubeck)
Comment 3•12 years ago
|
||
Whoops. That was the wrong patch. This is the one I thought I uploaded. I'm curious your opinions on both though. The other patch moves us from using ShowPress to using touchstart for showing the tap highlight. I think it feels a bit quicker and more responsive, and I'd be happy to move to it (should also stop sending the message from Java I realize as I'm writing this).
Attachment #602437 -
Flags: review?(mbrubeck)
Updated•12 years ago
|
Attachment #602433 -
Flags: review?(mbrubeck) → review+
Comment 4•12 years ago
|
||
Comment on attachment 602437 [details] [diff] [review] Patch 2 Both of these patches look good to me.
Attachment #602437 -
Flags: review?(mbrubeck) → review+
Comment 5•12 years ago
|
||
(In reply to Wesley Johnston (:wesj) from comment #3) > Created attachment 602437 [details] [diff] [review] > Patch 2 > I dislike this patch; it seems like you're overloading the viewport-setting mechanism for quasi-unrelated purposes. It's more of a maintainability problem than a correctness problem, although it may become a correctness problem with the changes we've made on maple.
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f5e40eb37c1 https://hg.mozilla.org/integration/mozilla-inbound/rev/4253a5a838a8
Comment 8•12 years ago
|
||
Backed out because of some strange failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/a61b13046123 this isn't a blocker, just some happy cleanup i was doing. I can dig into it when I get some time this week, but i don't have time at the moment.
Updated•12 years ago
|
blocking-fennec1.0: --- → ?
Updated•12 years ago
|
blocking-fennec1.0: ? → soft
Comment 10•12 years ago
|
||
Bumped to release blocker after discussing with product/ux. Can we revisit these patches?
blocking-fennec1.0: soft → +
Comment 11•12 years ago
|
||
This is believed to be when you double tap to zoom, a link may get highlighted (and never un-highlighted) but not activated.
Comment 12•12 years ago
|
||
There are patches in here, but I assume they are obsolete now?
Not sure about the patch; just confirming that this bug still exists. Tested on Droid 2, Nightly 05/2/2012
Comment 14•12 years ago
|
||
The patch just landed today (bug 744518). Nightly will not have it.
Comment 15•12 years ago
|
||
I guess we can mark this fixed by bug 744518.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 16•12 years ago
|
||
Switching to a dupe so we don't track it as a possible uplift.
Resolution: FIXED → DUPLICATE
Reporter | ||
Comment 17•12 years ago
|
||
I can still reproduce this in today's trunk build.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 18•12 years ago
|
||
Yeah. More sporadic now, but I can still reproduce, usually during page load. We're racing between when we get the doubletap message from java (which is out of our control) and when we get touchstart in the page. Trying to think of a better solution...
Comment 19•12 years ago
|
||
Wes - Has the tapping/gesture code changed recently to allow us to take another shot at this bug?
Comment 20•12 years ago
|
||
I've been hoping I'd have a stroke of genius. I think we need to ensure we clear tap highlight whenever the viewport changes. I'll look into that today.
Comment 21•12 years ago
|
||
Re-triaging to strip out non-OMG-ON-FIRE release blockers - pushing this to .N+ but we'd still love to look at a safe patch.
blocking-fennec1.0: + → .N+
Comment 22•12 years ago
|
||
Wes, are you still working on this? Going to need a patch soon-ish for .N
Updated•12 years ago
|
blocking-fennec1.0: .N+ → -
Comment 23•12 years ago
|
||
http://support.mozilla.org/en-US/questions/931394
Status: REOPENED → ASSIGNED
status-firefox-esr10:
--- → affected
status-firefox14:
--- → affected
status-firefox15:
--- → affected
Updated•12 years ago
|
status-firefox-esr10:
affected → ---
status-firefox16:
--- → affected
Comment 26•12 years ago
|
||
This issue is still reproducing on the latest Nightly build. -- Firefox 18.0a1 (2012-08-28) Device: Galaxy Note OS: Android 4.0.4
status-firefox14:
affected → ---
status-firefox15:
affected → ---
status-firefox17:
--- → affected
status-firefox18:
--- → affected
Comment 27•12 years ago
|
||
What's the status of these patches here?
Comment 28•12 years ago
|
||
These patches are all obsolete or checked in. I will check in bug 769857 this morning and it MAY help slightly.
Comment 29•11 years ago
|
||
Not actively working on.
Updated•11 years ago
|
Assignee: wjohnston → nobody
Whiteboard: [mentor=wesj][lang=js]
Assignee | ||
Updated•10 years ago
|
Mentor: wjohnston
Whiteboard: [mentor=wesj][lang=js] → [lang=js]
Updated•7 years ago
|
Mentor: wjohnston2000
Comment 30•6 years ago
|
||
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195 Needinfo :susheel if you think this bug should be re-triaged.
Priority: P3 → P5
Comment 32•6 years ago
|
||
No assignee, updating the status.
Comment 33•3 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 12 years ago → 3 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•