Paul Irish Reporter
	Description • 13 years ago

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/535.4 (KHTML, like Gecko) Chrome/16.0.887.0 Safari/535.4

Steps to reproduce:

- about:config
- set geo.enable to false
- try:

navigator.geolocation && navigator.geolocation.getCurrentPosition(
  function(){ console.log('success', arguments); },
  function(){ console.log('error', arguments);    }
);


Actual results:

getCurrentPosition threw an exception: 
[11:44:41.359] [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDOMGeoGeolocation.getCurrentPosition]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: Web Console :: <TOP_LEVEL> :: line 1"  data: no]


Expected results:

Ideally navigator.geolocation is undefined, so feature detection is accurate. Pages relying on detecting navigator.geolocation exists are changing behavior expecting it to succeed (or at least, prompt the user).

Next best thing is the error callback is executed.

	Josh Matthews [:jdm] Assignee
	Comment 1 • 13 years ago

Agreed, this DOM call shouldn't throw.

	Josh Matthews [:jdm] Assignee
	Comment 3 • 13 years ago

Comment on attachment 561469 [details] [diff] [review]
Make navigator.geolocation if geolocation is disabled.

Doug, is navigator.geolocation returning null a decent behaviour here?

	Doug Turner (:dougt)
	Comment 4 • 13 years ago

Comment on attachment 561469 [details] [diff] [review]
Make navigator.geolocation if geolocation is disabled.

this is okay... but I still think people will be able to test for interface Geolocation, and NavigatorGeolocation.

	Josh Matthews [:jdm] Assignee
	Comment 5 • 13 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/8232007db7e5

	(no longer active)
	Comment 6 • 13 years ago

https://hg.mozilla.org/mozilla-central/rev/8232007db7e5