Luis Villa Reporter
	Description • 14 years ago

When I create a 'new folder' in finder or other file managers, the folder name field is immediately focused so that I can type the new folder's name. 

I have the same expectation when creating a new group, but instead I get search.

Current behavior:
1) click and drag to create new tab group
2) type 'foo' to name the group, hit enter
3) get told there are no search results for foo.

Expected behavior:
1) click and drag to create new tab group
2) type 'foo' to name the group, hit enter
3) the group is now named 'foo'

Would be nice for this to Just Work. :)

	Kevin Hanes
	Comment 1 • 14 years ago

That certainly seems like the sort of behavior we want! Adding it to the b9 (fit n' finish beta) list so we can discuss it more when we get there.

	Kevin Hanes
	Comment 2 • 14 years ago

bugspam (moving b9 to b10)

	Kevin Hanes
	Comment 3 • 14 years ago

bugspam (removing b9)

	Kevin Hanes
	Comment 4 • 14 years ago

Punting

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 5 • 13 years ago

@Alex: the patch focuses the title input field when using mouse drag to create a new tab group. Shall we also focus the input field when creating a group via dragging a tabItem onto an orphan tab? Without the orphan tab concept we would immediately create a new group when dragging a tab out of its group.

I don't feel like it's the right thing to focus the input field when not explicitly creating a new group but it's up to you :)

	Raymond Lee [:raymondlee]
	Comment 6 • 13 years ago

Comment on attachment 537601 [details] [diff] [review]
patch v1

+  if (options.focusTitle)
+    this.focusTitle();
+

Nit: Please add a comment about options.focusTitle to the method input variable options.

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 7 • 13 years ago

Comment on attachment 537601 [details] [diff] [review]
patch v1

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=1ef959a9e308

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 9 • 13 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/d8b5c9736831

	Boris Zbarsky [:bzbarsky]
	Comment 10 • 13 years ago

Backed out due to mochitest-other orange.

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 11 • 13 years ago

Extended patch (and test) to auto-focus the title field when creating a new group by dragging a tab onto an orphan tab (as requested by Limi).

	(no longer active)
	Comment 12 • 13 years ago

Do we know what was wrong with the original patch which caused this to be backed out?

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 13 • 13 years ago

(In reply to comment #12)
> Do we know what was wrong with the original patch which caused this to be
> backed out?

I relanded all other patches except bug 633190 - that was actually causing this intermittent orange. So this patch should be safe.

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 14 • 13 years ago

Comment on attachment 538527 [details] [diff] [review]
patch v3

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=3b0da64388be

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 15 • 13 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/d58376753a93

	Tim Taubert [:ttaubert] (inactive) Assignee
	Comment 16 • 13 years ago

http://hg.mozilla.org/mozilla-central/rev/d58376753a93

	George Carstoiu
	Comment 17 • 13 years ago

Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110615 Firefox/7.0a1

Verified issue on Ubuntu 11.04 x86, Mac OS X 10.6, Win 7 x86, WinXP using the steps from the Description.

Issue no longer present - changing status to Verified.