magicp Reporter
	Description • 8 years ago

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160820030224

Steps to reproduce:

1. Start Nightly
2. Go to "http://helloracer.com/webgl/"
3. Open DevTools > Shader Editor
4. Click "Reload" button
5. Check "Toggle geometry visibility" icon


Actual results:

Toggle geometry visibility icon is gone, because itemToggle.png was already replaced to itemToggle.svg in Bug 1260523.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=a097b61f58102776941bd3fa0023092ac3f27a3f&tochange=006a4f4e68522332a36fd7eccd9664b73efae975


Expected results:

Fix itemToggle icon url in shadereditor.css

	Tim Nguyen :ntim Assignee
	Comment 2 • 8 years ago

MozReview-Commit-ID: 6LZfdklnm0o

	Tim Nguyen :ntim Assignee
	Comment 3 • 8 years ago

MozReview-Commit-ID: 6LZfdklnm0o

	Tim Nguyen :ntim Assignee
	Comment 4 • 8 years ago

Comment on attachment 8785129 [details] [diff] [review]
Fix erronous references to itemToggle.png

opacity: 0.3 is consistent with what we do in the styleeditor

	Pulsebot
	Comment 5 • 8 years ago

Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/5cefc6af9611
Fix erronous references to itemToggle.png. r=bgrins

	Tim Nguyen :ntim Assignee
	Comment 6 • 8 years ago

Comment on attachment 8785129 [details] [diff] [review]
Fix erronous references to itemToggle.png

Approval Request Comment
[Feature/regressing bug #]: bug 1260523
[User impact if declined]: broken shader editor UI (the item checkbox doesn't appear)
[Describe test coverage new/current, TreeHerder]: local testing + in fx-team, soon in Nightly
[Risks and why]: low, css only 
[String/UUID change made/needed]: no

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/5cefc6af9611

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 8 • 8 years ago

Hello magicp, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 9 • 8 years ago

Comment on attachment 8785129 [details] [diff] [review]
Fix erronous references to itemToggle.png

Fixes a regression, Aurora50+

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 10 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/c3e815e20c7f

	Nawaf Chowdhury Akash
	Comment 11 • 8 years ago

I have reproduced this bug with Firefox Nightly 51.0a1 (2016-08-21) on Windows 10, 32-bit.

Verified as fixed with Latest Firefox nightly 51.0a1 (Build ID 20160830030201)
User Agent :Mozilla/5.0 (Windows NT 10.0; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160824]

	magicp Reporter
	Comment 12 • 8 years ago

(In reply to Ritu Kothari (:ritu) from comment #8)
> Hello magicp, could you please verify this issue is fixed as expected on a
> latest Nightly build? Thanks!

verified on a latest Nightly and Aurora. Thanks!