Julian Descottes [:jdescottes] Assignee
	Description • 8 years ago

STRs:
- open the inspector
- select a node with valid css properties (e.g. not a comment)
- go to the Computed tab
- enter some value in the filter which will not match anything

ER:
The message "No CSS properties found." should be displayed

AR:
The panel is empty.

This is a regression from Bug 1238133. The ruleview creates an element with the id "noResults" (dynamically, in devtools/client/inspector/rules/rules.js), and the computed view uses another element with the same id, declared in inspector.xul.

Now that the two views live in the same document, document.getElementById("noResults") always returns the element from the ruleview.

We should either use different ids or rely on a classname.

	Julian Descottes [:jdescottes] Assignee
	Comment 1 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/61792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61792/

	Julian Descottes [:jdescottes] Assignee
	Comment 2 • 8 years ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4043fbd4114

	Julian Descottes [:jdescottes] Assignee
	Comment 3 • 8 years ago

Comment on attachment 8767118 [details]
Bug 1283764 - fix display of noResults message in inspector computedview;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61792/diff/1-2/

	Gabriel Luong [:gl] (ΦωΦ)
	Comment 4 • 8 years ago

Comment on attachment 8767118 [details]
Bug 1283764 - fix display of noResults message in inspector computedview;

https://reviewboard.mozilla.org/r/61792/#review58584

	Julian Descottes [:jdescottes] Assignee
	Comment 5 • 8 years ago

Thanks for the review! 

Sent to try again after fixing two tests that had a reference to the old ids: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aaa0703b75f24820beb562dc6dc74bdde4645d62

Try is green, checkin-needed.

	Pulsebot
	Comment 6 • 8 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/05cb30a038a2
fix display of noResults message in inspector computedview;r=gl

	Phil Ringnalda (:philor)
	Comment 7 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/05cb30a038a2

	Forhad Hossain
	Comment 8 • 8 years ago

I have reproduced this bug with Nightly 50.0a1(2016-07-01) with instruction from comment 0 and Linux x86. 

The Bug's fix is now verified on Latest Developer Edition 50.0a2(2016-08-17)
Build ID:20160817004002
User Agent:Mozilla/5.0 (X11; Linux i686; rv:50.0) Gecko/20100101 Firefox/50.0

[bugday-20160817]

	Mohammad Maruf Rahman
	Comment 9 • 8 years ago

I have reproduced this bug with Nightly 50.0a1 (2016-07-01) on Windows 7, 64 Bit!

This bug's fix is verified with latest Developer Edition (Aurora)

Build   ID   20160803004014
User Agent   Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0 

[testday-20160826]