Justin Wood (:Callek) Assignee
	Description • 8 years ago

We failed in release runner with:

2016-01-27 02:42:09,255 : ERROR : found in browser/config/mozconfigs/macosx-universal/nightly but not in browser/config/mozconfigs/macosx-universal/beta: . "$topsrcdir/build/macosx/mozconfig.rust"

per IRC:
<Callek> Sylvestre: three options then. (a) add it to the whitelist which will allow the beta build to proceed [without rust] - risk: could have bustage where the build may expect rust. (b) add rust to the beta/release mozconfigs  - risk: I'm not sure if the rust feature is beta-ready. (c) wait for rillian and slip beta more
<Sylvestre> b seems better 
<Callek> Sylvestre: I'll get it in a bug and land with a=you (over IRC)

This patch will land on aurora/m-c as well, but I'm looking to unblock beta first.

	Justin Wood (:Callek) Assignee
	Comment 1 • 8 years ago

Difference from previous patch is this removes it from the whitelist as well.

	Justin Wood (:Callek) Assignee
	Comment 2 • 8 years ago

Comment on attachment 8712658 [details] [diff] [review]
[beta] rust - v2

https://hg.mozilla.org/releases/mozilla-beta/rev/76fdbc5ce8ea

	Ralph Giles (:rillian)
	Comment 3 • 8 years ago

I'm fine with this going to release. Code has been stable so far, and we welcome wider testing.

It's also ok to turn it off in current beta; we're testing the non-rust code path on windows and android.

	Sylvestre Ledru [:Sylvestre]
	Comment 4 • 8 years ago

Comment on attachment 8712658 [details] [diff] [review]
[beta] rust - v2

Approving for posterity

	Justin Wood (:Callek) Assignee
	Comment 5 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/33115/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33115/

	Justin Wood (:Callek) Assignee
	Comment 6 • 8 years ago

Comment on attachment 8714494 [details]
MozReview Request: Bug 1243363 - Add rust to beta and release mozconfigs. r?rail

fyi -- this is same as the beta patch, just rebased. And using mozreview -- because its soon to be the new thing ;-)

	Rail Aliiev [:rail]
	Comment 7 • 8 years ago

Comment on attachment 8714494 [details]
MozReview Request: Bug 1243363 - Add rust to beta and release mozconfigs. r?rail

https://reviewboard.mozilla.org/r/33115/#review29961

	Pulsebot
	Comment 8 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/15d596fb43b6

	Pulsebot
	Comment 9 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/41e45ac56256

	Justin Wood (:Callek) Assignee
	Comment 10 • 8 years ago

I was broken due to Bug 1243037 - but I just pushed a fix (point the rust mozconfig for linux/mac at the right place)

	Justin Wood (:Callek) Assignee
	Comment 11 • 8 years ago

Hey Nathan,

While I fixed this bug on trunk, and will be pushing to aurora once approved, I noticed that just a few weeks ago you enabled rust on windows.

If that rides to beta we'll be risking shipping codepaths that we don't test, can you either duplicate the in-tree parts of this bug for windows too, or confer with relman and link said convo to this bug that indicates we're explicitly *not* wanting rust to ride to beta on windows.

	Justin Wood (:Callek) Assignee
	Comment 12 • 8 years ago

Comment on attachment 8714494 [details]
MozReview Request: Bug 1243363 - Add rust to beta and release mozconfigs. r?rail

The lack of this patch broke beta, so we need to port to aurora as well for next cycle.

	Nathan Froyd [:froydnj]
	Comment 13 • 8 years ago

(In reply to Justin Wood (:Callek) from comment #11)
> If that rides to beta we'll be risking shipping codepaths that we don't
> test, can you either duplicate the in-tree parts of this bug for windows
> too, or confer with relman and link said convo to this bug that indicates
> we're explicitly *not* wanting rust to ride to beta on windows.

I can do that.  Who would be the person to talk to on the relman side of things about this?

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 14 • 8 years ago

Does this also affect 47?
Tracking for 45+ for now. 
Should this block release?

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 15 • 8 years ago

OK, after talking more with callek I am still not clear what the issues are here. Sounds like I should talk with him, sylvestre, and nathan soon to figure this out. needinfo to myself so I don't forget this tomorrow.

	Carsten Book [:Tomcat]
	Comment 16 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/15d596fb43b6
https://hg.mozilla.org/mozilla-central/rev/41e45ac56256

	Carsten Book [:Tomcat]
	Comment 17 • 8 years ago

sylvestre: should this land on beta too ?

	Sylvestre Ledru [:Sylvestre]
	Comment 18 • 8 years ago

"status-firefox45: fixed" => looks like it is not necessary but I might have missed the info.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 19 • 8 years ago

Comment on attachment 8714494 [details]
MozReview Request: Bug 1243363 - Add rust to beta and release mozconfigs. r?rail

Sounds like we just need to add this in preparation to ship some rust code to beta during the next cycle. OK to uplift to aurora.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 20 • 8 years ago

Nathan is there still more work you need to do to support windows? Do you want to open a new bug for that?

	Ralph Giles (:rillian)
	Comment 21 • 8 years ago

Windows works, pending review on bug 1248461. I'll open a new bug to let win64 ride the trains like the other platforms.

	Nathan Froyd [:froydnj]
	Comment 22 • 8 years ago

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #20)
> Nathan is there still more work you need to do to support windows? Do you
> want to open a new bug for that?

Yes, and we already have bugs open for that work.

	Carsten Book [:Tomcat]
	Comment 23 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=c78d4c97956b

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 24 • 8 years ago

Justin, this bug is tracked for 47. I believe it should be fixed in 47. Am I mistaken?

	Justin Wood (:Callek) Assignee
	Comment 25 • 8 years ago

afaict it is indeed fixed for 47