Mark Hammond [:markh] [:mhammond] Assignee
	Description • 8 years ago

There is a "Synced Tabs" item on the history panel. This has |disabled="true"| defined in the XUL and while the code correctly manages the hidden state of the item it never removes the disabled attribute. The end result is that the item is correctly hidden when Sync is not configured, but shown and disabled when it is.

	Pulsebot
	Comment 1 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/55d6be76fac9

	Mark Hammond [:markh] [:mhammond] Assignee
	Comment 2 • 8 years ago

Comment on attachment 8705900 [details] [diff] [review]
0001-Bug-XXXXXXX-Synced-Tabs-entry-on-history-panel-is-al.patch

Approval Request Comment
[Feature/regressing bug #]: Synced Tabs Panel UI
[User impact if declined]: "Synced Tabs" on the history panel will be disabled for Sync users.
[Describe test coverage new/current, TreeHerder]: Existing tests pass.
[Risks and why]: Trivial 1 line patch
[String/UUID change made/needed]: None

	Carsten Book [:Tomcat]
	Comment 3 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/55d6be76fac9

	Carsten Book [:Tomcat]
	Comment 4 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/62a772079ed9

	Vasilica Tamas, QA [:vtamas]
	Comment 5 • 8 years ago

I was able to reproduce this issue on Firefox 46.0a1 (2016-01-08) under Windows 10 64-bit.

Verified fixed on Firefox 46.0a1 (2016-01-13/14) and Firefox 45.0a2 (2016-01-14) using Windows 10 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5.