Closed
Bug 1236481
Opened 8 years ago
Closed 8 years ago
'Synced Tabs' History menuitem not shown because PlacesUIUtils.shouldEnableTabsFromOtherComputersMenuitem has been removed
Categories
(Firefox :: Sync, defect)
Tracking
()
VERIFIED
FIXED
Firefox 46
People
(Reporter: aryx, Assigned: aryx)
References
Details
(Keywords: regression, Whiteboard: [push patch to mozilla-aurora, applies without issues])
Attachments
(1 file)
40 bytes,
text/x-review-board-request
|
markh
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
Firefox Aurora and Nightly 20160103 on Windows 8.1 The 'Synced Tabs' menu item in the 'History' menu doesn't get shown. Fehler: TypeError: PlacesUIUtils.shouldEnableTabsFromOtherComputersMenuitem is not a function Quelldatei: chrome://browser/content/browser-places.js Zeile: 742 Regression from bug 1201331.
Updated•8 years ago
|
status-firefox45:
--- → affected
status-firefox46:
--- → affected
Assignee | ||
Comment 1•8 years ago
|
||
My first review request over Mozreview, please excuse if I did something unexpected.
Attachment #8703580 -
Flags: review?(markh)
Comment 2•8 years ago
|
||
(In reply to Sebastian H. [:aryx][:archaeopteryx] from comment #1) > My first review request over Mozreview, please excuse if I did something > unexpected. I don't know much about mozreview either, but I'm getting "access denied" viewing the patch: "This review request is private. You must be a requested reviewer, either directly or on a requested group, and have permission to access the repository in order to view this review request. " But I'm logged in to reviewboard via a bugzilla key...
Flags: needinfo?(aryx.bugmail)
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8703580 [details] MozReview Request: Bug 1236481 - 'Synced Tabs' History menuitem not shown. r?markh Review commit: https://reviewboard.mozilla.org/r/29403/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29403/
Attachment #8703580 -
Attachment description: mozreview request → MozReview Request: Bug 1236481 - 'Synced Tabs' History menuitem not shown. r?markh
Attachment #8703580 -
Attachment filename: file_1236481.txt → reviewboard-29403-url.txt
Assignee | ||
Comment 4•8 years ago
|
||
The request is now public on reviewboard.
Flags: needinfo?(aryx.bugmail)
Comment 5•8 years ago
|
||
Comment on attachment 8703580 [details] MozReview Request: Bug 1236481 - 'Synced Tabs' History menuitem not shown. r?markh https://reviewboard.mozilla.org/r/29403/#review26281 Awesome, thanks.
Attachment #8703580 -
Flags: review?(markh) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8bd38632b449
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8703580 [details] MozReview Request: Bug 1236481 - 'Synced Tabs' History menuitem not shown. r?markh Approval Request Comment [Feature/regressing bug #]: bug 1201331 [User impact if declined]: 'Synced Tabs' menu item will be missing from 'History' menu in menu bar. [Describe test coverage new/current, TreeHerder]: tested fix on mozilla-central [Risks and why]: Minimal (two lines of code removed, affected function tested) [String/UUID change made/needed]: None
Attachment #8703580 -
Flags: approval-mozilla-aurora?
Comment 9•8 years ago
|
||
Comment on attachment 8703580 [details] MozReview Request: Bug 1236481 - 'Synced Tabs' History menuitem not shown. r?markh Sure, taking in aurora.
Attachment #8703580 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Whiteboard: [push patch to mozilla-aurora, applies without issues]
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/8df38d86afb9
Keywords: checkin-needed
Comment 11•8 years ago
|
||
I was not able to access Synced Tabs panel from History menuitem. It appears as disabled on Firefox 46.0a1 (2016-01-07/08) under Windows 10 64-bit, Windows 8.1 32-bit, Mac OS X 10.10.5 and Ubuntu 12.04 32-bit. See screenshot: http://i.imgur.com/er7E8BT.jpg Any thoughts about this?
Flags: needinfo?(aryx.bugmail)
Assignee | ||
Comment 12•8 years ago
|
||
The behavior in that panel hasn't been altered. This patch affects the History menu from the menu bar (the one which gets shown when the user presses the Alt key). Before this patch, the 'Synced Tabs' menu item in that History menu in the menu bar didn't get shown anymore, even when logged in.
Flags: needinfo?(aryx.bugmail)
Updated•8 years ago
|
Flags: qe-verify+
Comment 13•8 years ago
|
||
I was able to reproduce this issue on Firefox 46.0a1 (2016-01-04) under Windows 10 64-bit. Verified fixed on Firefox 46.0a1 (2016-01-19) and Firefox 45.0a2 (2016-01-20) under Windows 10 64-bit, Mac OS X 10.10.5 and Ubuntu 13.10 64-bit. "Synced tabs" option is successfully displayed in History list from Menu Bar.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Updated•8 years ago
|
Version: unspecified → 45 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•