Closed Bug 1234202 Opened 9 years ago Closed 9 years ago

Warning message is not correctly displayed in submit review form

Categories

(Marketplace Graveyard :: Consumer Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
2015-12-22

People

(Reporter: cbadescu, Assigned: trishul.goel)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Details | Review
Steps to reproduce:
1.Go to any free app details page and click on "Write a review" button
2.Leave the form empty (no stars selected) and click the submit a review button.

Expected results:
Users should not be able to send reviews with a blank page and a warning message is correctly displayed.

Actual results:
The warning message is displayed under the browser "back" navigation arrow.

Notes/Issues:
Verified in FF 46 (Win 7-64) issue can be reproduced in MP-dev, stage and production.
Please see screencast for this bug: http://screencast.com/t/1WgXqWiDSiS
Attached file Pull Request
So this bug arose due to HTML5 validation, the radio button was 'display:none' so there was no position for warning message.
Assignee: nobody → trishul.goel
Status: NEW → ASSIGNED
PR Merged
https://github.com/mozilla/fireplace/pull/1594
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified as fixed in FF46(Win7) in marketplace-dev.allizom.org
Postfix screencast: http://screencast.com/t/FVp38dZv5
Closing bug.
Status: RESOLVED → VERIFIED
This issue is also in production.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: