Trishul Reporter
	Description • 9 years ago

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150716004006

Steps to reproduce:

1. Goto https://marketplace.firefox.com/recommended


Actual results:

List is displayed in condensed form but the button highlighted is of expanded view.


Expected results:

The condensed list button should be highlighted in case of condensed list display

	Atique Ahmed Ziad [:atiqueahmedziad]
	Comment 1 • 9 years ago

Also reproducible in `Popular` & `Categories`

	Trishul Reporter
	Comment 2 • 9 years ago

Shall I create another bug for `Popular` & `New`?

	Atique Ahmed Ziad [:atiqueahmedziad]
	Comment 3 • 9 years ago

No need :) you can fix all this issues in one commit and check if it can be changed globally for all :)

	Trishul Reporter
	Comment 4 • 9 years ago

Cool!

	frescoshashank Assignee
	Comment 5 • 9 years ago

I want to work on this bug. Please assign it to me :)

	Ram Dayal Vaishnav [:ram]
	Comment 6 • 9 years ago

Sure frescoshashank. Assigning you to this bug.

For any help you can refer to the documentation at http://marketplace.readthedocs.org/, or ask in #marketplace irc channel.

Thanks!

	frescoshashank Assignee
	Comment 7 • 9 years ago

I've completed the code changes, Please accept the pull request!

https://github.com/mozilla/fireplace/pull/1400

	Kevin Ngo [:ngoke]
	Comment 8 • 9 years ago

The UX is confusing, but when the button is grey, it is meant to mean that the button is pushed down and active. So it's intended to be that way.

	Ram Dayal Vaishnav [:ram]
	Comment 9 • 9 years ago

Kevin the grey one always looks like inactive, if we change it I think we will get better UX. 

NI'ing Liz to opine on this.

	Kevin Ngo [:ngoke]
	Comment 10 • 9 years ago

Either way, it will be confusing. Preferably we'd change it to a slider, or just get rid of the toggle.

	Ram Dayal Vaishnav [:ram]
	Comment 11 • 9 years ago

Slider looks better option :) Shall I log different bug for this?

	Elizabeth Hunt[:ezoehunt]
	Comment 12 • 9 years ago

Part of the confusion with the toggle is that the selected state is clickable. The selected state should NOT be clickable - only the active state (the view I want to change to) should be clickable.

Use of gray is also confusing. For another piece of work, I've suggested a lighter blue tone for the selected state. NIing Phil to get you that color - it doesn't exist yet in our palette.

A slider is not recommended at this time - we're trying to move away from this list/grid toggle altogether.

	Philip [:pwalm]
	Comment 13 • 9 years ago

This will be fixed as part of MOW P1. Light blue colour for reference: #40ADFF

	Ram Dayal Vaishnav [:ram]
	Comment 14 • 9 years ago

>> This will be fixed as part of MOW P1.

Phill can you please add the bug for above to this bug?