Closed
Bug 1177691
Opened 9 years ago
Closed 9 years ago
New and Popular text are not bold in a category page
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P4)
Tracking
(Not tracked)
VERIFIED
FIXED
2015-06-30
People
(Reporter: madalin.cotetiu, Assigned: trishul.goel)
References
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(1 file, 1 obsolete file)
Steps to reproduce: 1. Open a category page on your FFOS device (i.e: News) 2. Compare the New and Popular text with the one in the mocks: https://www.dropbox.com/s/cxclx4tdj2gxg46/MOW_Preload_v2.3.pdf?dl=0 (Page 6) Expected results: The New and Popular text is bold. Actual results: The New and Popular text is not bold. Notes/Issues: Verified in FFOS 2.1 (Flame) using the dev app Screencast for this issue: http://screencast.com/t/3q90pgf4lZ
Updated•9 years ago
|
Whiteboard: [good first bug][lang=css]
Updated•9 years ago
|
Severity: normal → trivial
Priority: -- → P4
PR : https://github.com/mozilla/fireplace/pull/1339 Kindly check my PR, if something more needs to be done, i will be glad to fix it.
Comment 3•9 years ago
|
||
Hi Trishul, You need sent each pull request for each bug. Please remove the another commit you made for another bug. That was maybe your last commit. So you can reset your last commit :) If you need any help, please ask !
As requested, PR with only one change.
Attachment #8626954 -
Attachment is obsolete: true
Comment 6•9 years ago
|
||
font-weight: bold gives us a font-weight of 600 here, which is very heavy. yesterday, talked with Philip,as philip said we should change the font-weight to 400. And I think if you just remove the font-weight:300 from there. It gets 400 by default.
Assignee: nobody → trishul.goel
Flags: needinfo?(softfilebd)
Updated PR : https://github.com/mozilla/fireplace/pull/1342
Flags: needinfo?(softfilebd)
Comment 8•9 years ago
|
||
For me Feedback+ Please squash the commits into one . You can use the follow commands `git rebase -i HEAD~2` pick the 1st one & squash the 2nd one then `git push -f` It will be rebased into one commit
Flags: needinfo?(softfilebd)
Squashed, and many thanks, actually I learned something new.
Comment 10•9 years ago
|
||
Fixed in https://github.com/mozilla/fireplace/commit/1523bba687e5a10a520242e3cfb9fb260cd5054e You can close this bug now.
Comment 11•9 years ago
|
||
Thanks for the patch, Trishul
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 12•9 years ago
|
||
Verified as fixed in mp-dev in FFOS 2.1(Flame) Postfix screencast: http://screencast.com/t/txrk0Z4nnTb Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•