Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Description • 9 years ago

Right now if we get an HB packet where the updated_ts is <= the one in the db, we log an error.

https://github.com/mozilla/fjord/blob/dad6bea148fa681a29e0848fa32ec6729da25429/fjord/heartbeat/api_views.py#L78

We know a lot about this error now. It's coming predominantly because the client fires off two HTTP POSTS one right after the other. Seems like it's not uncommon for the second to get handled before the first.

Given that, we stop recording the error. Just return an HTTP 400 to the client and move along.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 1 • 9 years ago

I think the way I want to fix this is to change rest_error() to have an argument specifying whether to log the error or not--have it default to logging the error.

Then change this use of rest_error() to tell rest_error() to not log the error.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 2 • 9 years ago

Passing this to LGuruprasad who just did it.

PR: https://github.com/mozilla/fjord/pull/526

Landed in master: https://github.com/mozilla/fjord/commit/026d9ae21d42d906231090c807771e8a0202097e

Will push out on next deploy.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 3 • 9 years ago

Pushed to prod just now.