Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Description • 9 years ago

We use pep8 with flake8 for some code convention linting. It makes it easier to maintain loose code conventions without spending all our time nit-picking in PR comments.

I had a short-lived fork of pep8 that included a fix to remove leading and trailing whitespace from paths in pep8 config file. This made it easier to list all the directories and files that should be excluded from checking. Otherwise if you had more than like 5, it was impossible to read and maintain.

They did a pep8 1.6.0 on February 6th which includes my fix. They've done a minor release since then.

We should update pep8 in the requirements/dev.txt file to 1.6.1.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 1 • 9 years ago

The file in question is requirements/dev.txt. We need to update the version of pep8 used and also compute the peep hash.

You can compute the peep hash by creating a virtual machine or virtual environment and running:

    ./peep.sh install -r requirements/dev.txt

It'll complain that there's no hash for the new pep8 line and tell you want it is. Add that line to the requirements file in the right place (you can look at other requirements for inspiration) and we should be all set.

Marking this as a mentored bug. If you're interested in working on it, please read through our "Join this project" guide [1], complete the list of things you need to do before contributing and then add a comment to this bug asking to have it assigned to you.

If you have any questions, please ask in the bug comments, on the mailing list or in the #input channel on irc.mozilla.org.

[1] http://fjord.readthedocs.org/en/latest/welcome.html

	L. Guruprasad Assignee
	Comment 2 • 9 years ago

In a pull request - https://github.com/mozilla/fjord/pull/487

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 3 • 9 years ago

Assigning this to lguruprasad who just did it.

Landed in master: https://github.com/mozilla/fjord/commit/7545259525129e559b4b3e95079cb4050d8fe5c3

This doesn't affect server environments, so I'm going to mark it FIXED.

Thank you!