Amy Tsay [:amyt] Reporter
	Description • 9 years ago

We need to add content guidelines for users who rate apps on Marketplace.

On the submission dialog (http://i.imgur.com/9FBR04T.png), add the following text: Please read the Review Guidelines for more details about rating apps. Reviews that do not meet these guidelines may be removed by our moderation team without notice.

Link the words "Review Guidelines" to a new static page (preferred URL: https://marketplace.firefox.com/review_guide)

Preferably, the design is based on this template: https://marketplace.firefox.com/privacy-policy

Content for this page: https://docs.google.com/a/mozilla.com/document/d/1IZk48hhJ7coq5s3L7U82BqplDEEfIvDlQ_5UfHjhaqc/edit#
(Scroll to the bottom half of doc)

	Wil Clouser [:clouserw]
	Comment 1 • 9 years ago

The content you linked to is all about AMO and add-ons.

Aside from that, I think this content belongs on MDN under https://developer.mozilla.org/en-US/Marketplace .  We've just managed to clear out all the long-form guides, docs, and policies out of the AMO codebase and onto MDN.  We should keep the same for Marketplace.

	Amy Tsay [:amyt] Reporter
	Comment 2 • 9 years ago

The Marketplace-specific content is farther down the page. I'm ok with it on MDN...however, can we still have the content and link on the submission dialog?

	Wil Clouser [:clouserw]
	Comment 3 • 9 years ago

Yes.  Can you give us a new URL?

	Amy Tsay [:amyt] Reporter
	Comment 4 • 9 years ago

Here you go: https://developer.mozilla.org/Marketplace/User_Review_Guidelines

	Wil Clouser [:clouserw]
	Comment 5 • 9 years ago

This is a good first bug and Andy has volunteered to help.  Let us know if you are in a hurry though.

	Ram Dayal Vaishnav [:ram] Assignee
	Comment 6 • 9 years ago

Hi Wil.. Can I work on this ?

	Wil Clouser [:clouserw]
	Comment 7 • 9 years ago

Sure - Andy is the mentor.  You can find him on IRC at andym (or ask in #marketplace).

This bug is all in the front end code (fireplace).  Instructions for installing fireplace can be found at https://github.com/mozilla/fireplace/ .  The template this string should be added on is https://github.com/mozilla/fireplace/blob/master/src/templates/ratings/add.html .  You don't need to worry about the "static page" stuff anymore since Amy put this on MDN.

I'm going to needinfo Liz who can help with the UI.  This has changed slightly since Amy's screenshot and I don't see a great place on this screen to add that many words.  Hopefully Liz will have good input. :)  Will attach screenshots in a minute...

	Ram Dayal Vaishnav [:ram] Assignee
	Comment 10 • 9 years ago

Hi Wil,

I have setup Docker on my system, and the instance is coming up. But how do I set up sample apps? I need to setup sample apps so that I can click on review button and test my changes.

PS: I will wait for Liz's input. For now, I just want to play around.

Thanks,
Ram Vaishnav

	Andrew Williamson [:eviljeff]
	Comment 11 • 9 years ago

(In reply to Ram Dayal Vaishnav [:Ram] from comment #10)
> Hi Wil,
> 
> I have setup Docker on my system, and the instance is coming up. But how do
> I set up sample apps? I need to setup sample apps so that I can click on
> review button and test my changes.

`` fig run --rm zamboni python manage.py generate_apps N ``

where N is the number of apps you want created in your database.

	Elizabeth Hunt[:ezoehunt]
	Comment 12 • 9 years ago

Ram, I spoke with Joni, and we updated the copy. See the attached "Submit Review" modal for where the 2 kinds of copy go. As you work on this, let me know if you have any questions!

	Wil Clouser [:clouserw]
	Comment 13 • 9 years ago

maybe we can get this on KTLO Chapter 2?

	Ram Dayal Vaishnav [:ram] Assignee
	Comment 14 • 9 years ago

Thanks Liz, I will submit the PR soon or ask you if I have any questions. Sorry for the delay.

	David Durst [:ddurst]
	Comment 15 • 9 years ago

Added to KTLO Chapter 2 (once it exists)

	Wil Clouser [:clouserw]
	Comment 16 • 9 years ago

Thanks.  I didn't realize Ram was still working on this.  Assigning back.

	Ram Dayal Vaishnav [:ram] Assignee
	Comment 17 • 9 years ago

Kindly r? https://github.com/mozilla/fireplace/pull/1163

Thanks,
Ram

	Wil Clouser [:clouserw]
	Comment 18 • 9 years ago

Looks like this was merged in.  Thanks Ram for the patch.

https://github.com/mozilla/fireplace/commit/eb3e02b4ec6ade277188864f0cd8cbb1a5fa9e83

	Madalin Cotetiu
	Comment 19 • 9 years ago

I have verified it in FF40(Win7) in marketplace.allizom.org. The message is displayed and the link is working. In the mock-up from comment 12 there is a new text in the "Update content here" section. At this moment in marketplace the message is: "Tell us what you love about this app" - Is this intended
Postfix screencast: http://screencast.com/t/Si30o9Pk8

Also the link to the review guidelines is not displayed on mobile devices (I have tested in Android 4.2.1 and Flame FFOS 2.0)- Intended or not?  Screencast: http://screencast.com/t/YPFj8Mw7

Will can you please respond?

	Wil Clouser [:clouserw]
	Comment 20 • 9 years ago

You're right, Madalin.  The screenshots in the PR had the updated text, but the final one does not.  I'm not sure what happened, but I'll reopen this.

	Ram Dayal Vaishnav [:ram] Assignee
	Comment 21 • 9 years ago

I will update the PR as required.

	Ram Dayal Vaishnav [:ram] Assignee
	Comment 22 • 9 years ago

Submitted another PR #1255 for putting back the placeholder text (which was removed as per previous discussion on PR #1163).

	Ram Dayal Vaishnav [:ram] Assignee
	Comment 23 • 9 years ago

Created another PR (#1354) as previous one was r+wc.

	Ram Dayal Vaishnav [:ram] Assignee
	Comment 24 • 9 years ago

Merged #1358. Closing the request, feel free to reopen if required. Thanks :)

	Madalin Cotetiu
	Comment 25 • 9 years ago

Verified as fixed in FF42(Win7) in marketplace-dev.
The text is updated and everything works as expected.
Closing bug.

	Amy Tsay [:amyt] Reporter
	Comment 26 • 9 years ago

\o/