Closed Bug 1130009 Opened 9 years ago Closed 9 years ago

Exception thrown when trying to run flake8 in the dev environment

Categories

(Input Graveyard :: Code Quality, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lgp171188, Assigned: lgp171188, Mentored)

Details

(Whiteboard: u=dev c=codequality p= s=input.2015q1)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Iceweasel/31.4.0
Build ID: 20150113100542

Steps to reproduce:

Login to the development VM and run flake8


Actual results:

(fjordvagrant)vagrant@vagrant-ubuntu-trusty-64:~/fjord$ flake8 
Traceback (most recent call last):
  File "/home/vagrant/.virtualenvs/fjordvagrant/bin/flake8", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/home/vagrant/.virtualenvs/fjordvagrant/local/lib/python2.7/site-packages/pkg_resources.py", line 2716, in <module>
    working_set.require(__requires__)
  File "/home/vagrant/.virtualenvs/fjordvagrant/local/lib/python2.7/site-packages/pkg_resources.py", line 685, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/home/vagrant/.virtualenvs/fjordvagrant/local/lib/python2.7/site-packages/pkg_resources.py", line 588, in resolve
    raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: mccabe>=0.2.1



Expected results:

flake8 should have run without any exceptions
When we initially added a requirements/dev.txt, we added just the required packages and not their dependencies since we were installing them directly using pip. Not sure if making it installable using peep has broken this since the dependencies are not specified in requirements/dev.txt. Have to hear from willkg on this.
Whoops--that's totally my fault when I switched the way to install dev.txt from pip to peep.

We'll need to add pep8, pyflakes and mccabe to the dev.txt requirements list with their appropriate peep hashes.
In a PR: https://github.com/mozilla/fjord/pull/480

Landed in master: https://github.com/mozilla/fjord/commit/9d009d7eed38dfe73a3a18f9340a6413528eac3f

Marking as FIXED since this doesn't affect production.
Assignee: nobody → lgp171188
Mentor: willkg
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: u=dev c=codequality p= s=input.2015q1
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.