Closed Bug 1124497 Opened 9 years ago Closed 9 years ago

feedback_responsetroubleshootinginfo is the WORST TABLE NAME EVER!!!11!!

Categories

(Input Graveyard :: Submission, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

(Whiteboard: u=sanity c=feedback p=1 s=input.2015q1)

Hystrionics aside, the name sucks. The model name also sucks. It was a terrible idea to name it that. I blame myself. I'm extraordinarily sorry now.

This bug covers renaming it.

Not so fast! It's not trivial to rename it. We need to:

1. commit 1: create the new model and a schema migration to create the new model

2. commit 2: create a data migration to copy everything over from the old model to the new model and also update all the code to use the new model

3. commit 3: delete the old model and create a schema migration to delete the old table
Grabbing this and making it a P1 because it's really irritating and Cheng dislikes it, too.

Further, Mike pointed out we can't use the BGB to land this--we should rebase it in so that we can back undeploy specific commits if we need to. That way the history is linear.

E.g. This is what we want to end up with:

o---o---o---A---c1---c2---c3-->HEAD

This is bad:

o---o---o---A---merge-->HEAD
 \             /
  c1---c2---c3

Because if prod is on A, in order to deploy c1, we essentially undeploy some commits.
Assignee: nobody → willkg
Priority: -- → P1
cc:ing Cheng and Rob so they know when stuff happens.
Talked to Cheng. We're going to change the model to ProductInfo.
Status: NEW → ASSIGNED
Whiteboard: u=sanity c=feedback p= s=input.2015q1 → u=sanity c=feedback p=2 s=input.2015q1
Cheng pointed out I have the summary/description wrong. Fixing that. It's the ResponseTroubleshootingInfo model and the feedback_responsetroubleshootinginfo table.

Plus we're going to name the table ResponsePI.
Summary: feedback_remotetroubleshootinginfo is the WORST TABLE NAME EVER!!!11!! → feedback_responsetroubleshootinginfo is the WORST TABLE NAME EVER!!!11!!
Making this a 1 pointer since it was pretty fast to do.
Whiteboard: u=sanity c=feedback p=2 s=input.2015q1 → u=sanity c=feedback p=1 s=input.2015q1
Pushed to prod just now.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.