Closed
Bug 1124379
Opened 9 years ago
Closed 9 years ago
upgrade peep and create peep.sh script
Categories
(Input Graveyard :: Code Quality, defect)
Input Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
(Whiteboard: u=dev c=codequality p=2 s=input.2015q1)
Fjord uses peep to update requirements in the vagrant vm that contributors use for their development environments. When I update peep, I re-do a set of modifications to it which prevent peep/pip from downloading or using wheels. That's great because then no one has to remember to avoid wheels and the instructions for usage are the same regardless of which version of pip you're using. However, it's problematic because I have to re-do the modifications and I don't have a good test harness for it and so I'm not testing across all the things peep tests across. Anyhow, this bug covers: 1. moving ./peep to ./bin/peep.py 2. upgrading ./bin/peep.py to the latest version (2.1 I think) 3. creating a ./peep.sh bash script which figures out which version of pip is being used and calls ./bin/peep.py with the appropriate "i don't want to use wheels, kthx" flag 4. updating the docs to talk about peep.sh 5. updating the vagrant_provision.sh script to use peep.sh 6. sending an email to input-dev about the change 7. whatever other things need to be done/updated
Assignee | ||
Comment 1•9 years ago
|
||
Grabbing this one because our current situation is icky.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/470
Assignee | ||
Comment 3•9 years ago
|
||
Landed in https://github.com/mozilla/fjord/commit/0bb2e563deca3e71eb6b10c17770d0af9df2d4e3 Will mark this FIXED now since it involves things that aren't pertinent to production.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•9 years ago
|
||
Making this a 2 pointer since I've been mulling over it for a while and it took a while to implement and test.
Whiteboard: u=dev c=codequality p= s=input.2015q1 → u=dev c=codequality p=2 s=input.2015q1
Assignee | ||
Comment 5•9 years ago
|
||
Updated to peep 2.2 in PR: https://github.com/mozilla/fjord/pull/475 Landed in master: https://github.com/mozilla/fjord/commit/2ef80991bd33e14e0df3914ce504557e1bd0f71f
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•