Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Description • 9 years ago

The Thank You page project will require a waffle flag so that we can implement and test it before anyone else sees it.

To create the flag, we'll need to:

1. figure out a name for it
2. create a data migration for the feedback app

This bug covers creating that waffle flag.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 1 • 9 years ago

Documentation for django-waffle is here: http://waffle.readthedocs.org/en/latest/

In particular, we're going to create a Flag: http://waffle.readthedocs.org/en/latest/types.html#flags

We're going to create it using a data migration. Doing a data migration allows us to make sure all Fjord environments (dev environments, -dev servers, -stage servers and -prod servers) get the flag just by running:

./manage.py migrate

That makes it pretty convenient.

Here's an example data migration that creates a flag:

https://github.com/mozilla/fjord/blob/945eab73d558b2c0a39a880068d33cf30730a110/fjord/base/migrations/0004_create_chart_flag.py

Most of that is auto-generated using the datamigratation command:

./manage.py datamigration

There's documentation I just wrote that covers making data migrations for things like waffle flags.

http://fjord.readthedocs.org/en/latest/db.html#creating-a-data-migration

	aokoye Assignee
	Comment 2 • 9 years ago

PR https://github.com/mozilla/fjord/pull/443

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 3 • 9 years ago

Assigning this to Adam who did the work.

Landed in https://github.com/mozilla/fjord/commit/99217594250ba7a7e853609cb3bb27d293bd673f

Waiting until Monday to deploy and resolve.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 4 • 9 years ago

Pushed to production just now. Verified the flag exists. Marking as FIXED.

Thank you!

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 5 • 9 years ago

Moving things out of the input.adam sprint.