Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 10 years ago

Currently requests is pinned to 1.1 in requirements/requirements.txt.

This bug covers:

1. figuring out why we're pinned to that version (restrictions of another dependency?)

2. figure out how to upgrade requests to something modern

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 9 years ago

I'm not sure why I got needinfo'd on this bug.

	deshrajdry
	Comment 2 • 9 years ago

This is the first time when I am working on porting a python package to upgraded version. So, just wanted to know that how it works and what's the procedure to do porting.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 3 • 9 years ago

Ok--now I understand why you flagged me for info. This isn't a bug that's good for new contributors, so I don't think it's something you should work on.

	deshrajdry
	Comment 4 • 9 years ago

Can you help me in choosing a bug on which I should work on ?

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 5 • 9 years ago

You should ask questions like that either on IRC or on the input-dev mailing list. Links to those as well as the link to the list of mentored bugs are all in the docs:

http://fjord.readthedocs.org/en/latest/welcome.html

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 6 • 9 years ago

I don't see anything in vendor/ that requires requests <= 1.1. I think ok to update it. Let's update it to the most recent version: 2.5.1

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 7 • 9 years ago

In a PR: https://github.com/mozilla/fjord/pull/466

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 8 • 9 years ago

Landed in master: 

https://github.com/mozilla/fjord/commit/15b19b295977ffbc48449f3985121812508440c8
https://github.com/mozilla/fjord/commit/83079bffb32d635375d1500af8cbe442cce04a34

Will push on Monday.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 9 • 9 years ago

Pushed this to production just now. Marking as FIXED.