Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Description • 10 years ago

If a user who has JavaScript disabled attempts to leave feedback, they're met with a broken form.

We should add a <noscript> section that tells the user that JavaScript is required to leave feedback and that they should enable it and refresh the page.

Pretty sure this is as easy as:

<noscript>
<p>
{{ _('JavaScript is required to leave feedback. Please enable JavaScript in your browser and refresh this page.') }}
</p>
</noscript>

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 1 • 10 years ago

We should run the language by Matej first.

	Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )
	Comment 2 • 10 years ago

(do you want to support a 'mailto' link for these people?  If trivial (since you are making a string change), then might be a good supplement.   Assuming you have an address.  And you want to take mail.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 3 • 10 years ago

I've thought about this for 30 seconds and I'm not wildly excited about email. I suspect that stems partly from the fact it provides another vector for spam. I've only thought about it for 30 seconds, though.

Regardless, if we wanted to add an email-based feedback thing, I'd have to push that aspect off until later. Pretty sure that's a chunk of work to do.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 4 • 10 years ago

Adam: I think this is a good one to work on next. The file you want to look at is fjord/feedback/templates/feedback/generic_feedback.html .

There's a {% block body %} section. At the top of that section, we want to add something like:

<noscript>
<p>
{{ _('JavaScript is required to leave feedback. Please enable JavaScript in your browser and refresh this page.') }}
</p>
</noscript>

After you add that, try disabling JavaScript in your browser and then loading the page. The page may not work well, but that's ok so long as that message shows at the top of the page.

I don't know offhand how to disable JavaScript. There might be a SUMO article about it. You should be able to do an Internet search for the answer.

	Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )
	Comment 5 • 10 years ago

(to disable js:  about:config > javascript.enabled ==> false).

I almost just (foolishly) suggested that we Google Analytics record when NOSCRIPT shows.  /me headsmack.

The "enable javascript" should be a link (if there is a good one!  maybe:  https://support.mozilla.org/en-US/questions/967344).  

Cheers!

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 6 • 10 years ago

Yeah, it'd be great to get metrics, but I don't think we have any way to do that. We could have a link to a "me, too" page where they can register their disappointment. Counting the number of requests (with some filtering somehow) might be an ok metric.

	Ricky Rosario [:rrosario, :r1cky]
	Comment 7 • 10 years ago

I am pretty sure you can put a pixel that points to GA inside the <noscript>. like:

<noscript><img src="https://analytics.google.com/some/awesome/pixel.gif?some=awesome&parameters=here"/></noscript>

Not sure if that helps or not...

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 8 • 10 years ago

Oh clever!

Adam: Let's get the basic page working and tested. Then we can figure out and test the pixel thing.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 9 • 10 years ago

PR: https://github.com/mozilla/fjord/pull/423

Landed in master: https://github.com/mozilla/fjord/commit/1fc67a3348d3f5262e06877fb215d06e24ba9f02

We're in a deploy freeze, so this will wait to go out until the freeze is lifted.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 10 • 9 years ago

Pushed this to production just now. Verified that it's working.

Marking as FIXED.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 11 • 9 years ago

Moving things out of the input.adam sprint.