ori Reporter
	Description • 10 years ago

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20141206030202

Steps to reproduce:

Click "Nightly" → "Preferences..." → "Content"


Actual results:

Under "Fonts & Colors", the select list for the default font size shows an ellipsis instead of the selected value (16, in my case).


Expected results:

Because the font size is almost always a two-digit number, the select list should be wide enough to display two-digit values without collapsing them to an ellipsis.

	Loic
	Comment 1 • 10 years ago

It's fine with Win 7 and Nightly. It could be OSX-specific or DPI-dependant. Did you test with a clean profile?
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

	Paul Silaghi, QA [:pauly]
	Comment 2 • 10 years ago

WFM on nightly 37.0a1 (2014-12-07) OS X 10.9.5.

	:Gijs (he/him)
	Comment 3 • 9 years ago

(In reply to Paul Silaghi, QA [:pauly] from comment #2)
> WFM on nightly 37.0a1 (2014-12-07) OS X 10.9.5.

Ditto for me on today's... tentatively marking WFM. Ori, please let us know if you still see this and try to provide more information about the environment where you see this...

	:Gijs (he/him)
	Comment 4 • 9 years ago

... and then I saw it again myself today (on OS X). :-\

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 5 • 9 years ago

I think making the dropdown wider will be an easy fix for this.

	Tanay Pant [:Tanay]
	Comment 6 • 9 years ago

Hi Jared, this would be my first bug in Firefox, could you please tell me where the changes need to be made?

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 7 • 9 years ago

Hi Tanay, thanks for requesting to work on this bug.

The root issue here is that menulists that are missing an icon still have an extra 5px of margin-end applied to where the icon would be placed had it been provided.

If we only apply the margin when the icon is provided, this issue will be fixed and potentially other issues that are similar in symptom will also be fixed.

At http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css?rev=666746987b4b#207, we can change the following line:
xul|menulist > xul|*.menulist-label-box > xul|*.menulist-icon {
to
xul|menulist > xul|*.menulist-label-box > xul|*.menulist-icon[src] {

Doing this change would make the margin only apply when the src value is supplied. This fixes the issue in my testing.

	Tim Nguyen :ntim
	Comment 8 • 9 years ago

Bug 1013695 can also be handled here in my opinion.

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 10 • 9 years ago

Other locations this affects:

General -> When &brandShortName; starts:
Content -> Fonts & Colors -> Advanced… (ignoring font dimensions already mentioned in this bug)
Privacy -> Accept third-party cookies:, Keep until:

See https://bug1128173.bugzilla.mozilla.org/attachment.cgi?id=8557504 for a screenshot.

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 11 • 9 years ago

Tanay, can you apply the patch and see if this fixes the issue for you?

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/9fd93e84a01d

	Carsten Book [:Tomcat]
	Comment 13 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/9fd93e84a01d