Closed
Bug 1105435
Opened 10 years ago
Closed 9 years ago
increase back button hit target
Categories
(Input Graveyard :: Submission, defect)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: deshrajdry, Mentored)
Details
(Whiteboard: u=user c=feedback p= s=input.2015q1)
The hit target for the back button in the generic feedback form doesn't extend all the way to the left edge of the blue, but it probably should. Further, it should be extended to the right a bit, too. Doing these things will make it easier to hit.
Assignee | ||
Comment 1•10 years ago
|
||
Hey Will, I want to work on this bug. Please assgin it to me. Please provide the link and the necessary details.
Flags: needinfo?(willkg)
Reporter | ||
Comment 2•10 years ago
|
||
The feedback form in question is here: https://github.com/mozilla/fjord/blob/619f74618fa7d1b43f1e57e74ca095d2c3655324/fjord/feedback/templates/feedback/generic_feedback_form_dev.html I haven't looked into it at all, so I don't have any thoughts on how to fix it, yet. How do you think you would fix this?
Flags: needinfo?(willkg)
Assignee | ||
Comment 3•10 years ago
|
||
I will fix the bug by editing the current back button image and replacing it by new one. The new image will be more in width so as to give large area for clicking.
Reporter | ||
Comment 4•10 years ago
|
||
Ok. Two things to know: 1. the image is inline SVG 2. the hit target should extend all the way to the left edge of the blue header I suspect item 2 means you have to do more than just make the SVG bigger. Further, adjusting the size of the SVG might mean you have to adjust some other layout-type things in the header that are based on the width of the SVG. Assigning it to you. Let me know if you have any problems.
Assignee: nobody → deshrajdry
Mentor: willkg
Status: NEW → ASSIGNED
Whiteboard: u=user c=feedback p= s=input.2014q4
Assignee | ||
Comment 5•10 years ago
|
||
I have made a pull request. Have a look and let me know if changes are required.
Reporter | ||
Comment 6•9 years ago
|
||
The changes were in this PR: https://github.com/mozilla/fjord/pull/401 There were a lot of changes to the CSS, so we agreed to close the PR and try a different way that minimally changed things. Bumping to next quarter.
Whiteboard: u=user c=feedback p= s=input.2014q4 → u=user c=feedback p= s=input.2015q1
Assignee | ||
Comment 7•9 years ago
|
||
I have made changes to generic_feedback.less but unable to add it to the staging area since /static/ is listed in .gitignore file. So, now what should I do ?
Assignee | ||
Comment 8•9 years ago
|
||
Should I remove the /static/ from .gitignore ?
Reporter | ||
Comment 9•9 years ago
|
||
I suspect you're editing the wrong generic_feedback.less file. The one you should be editing is in fjord/feedback/static/css/generic_feedback.less . Is that the one you're editing?
Assignee | ||
Comment 10•9 years ago
|
||
Ok got it. I was editing the /static/css/generic_feedback.less . I have made changed and I am creating a pull request .
Reporter | ||
Comment 11•9 years ago
|
||
In a new PR: https://github.com/mozilla/fjord/pull/445 It's pretty close. One more change and undo some of the changes that don't need to be made and it should be good to go.
Reporter | ||
Comment 12•9 years ago
|
||
Landed in master: 55aa382 [bug 1105435] Increasing Hit Target of Back Button I'll push this to production on Monday. Good job!
Reporter | ||
Comment 13•9 years ago
|
||
Oops! Link to the commit: https://github.com/mozilla/fjord/commit/55aa38213abb19d5bffa26de2a0aa9e212d92ee6
Reporter | ||
Comment 14•9 years ago
|
||
Pushed to production just now. Marking as FIXED. Thank you!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•