Michael Maslaney [:mmaslaney] (mmaslaney@mozilla.com) Reporter
	Description • 10 years ago

Implement the updated In-content pref secondary dialogs.

Mocks:
http://people.mozilla.org/~mmaslaney/incontent/Preferences-dialog-types.png

Spec:
http://people.mozilla.org/~mmaslaney/incontent/Preferences-dialog-types-spec.png

	Tim Nguyen :ntim Assignee
	Comment 2 • 10 years ago

This patch :
- Updates the dialog styling
- Updates the tree styling (both to match the dialog spec)
- Note that I put the tree styling inside the shared file, since it's gonna be used for other in content pages

	Tim Nguyen :ntim Assignee
	Comment 3 • 10 years ago

Addressed feedback by mmaslaney.

	Tim Nguyen :ntim Assignee
	Comment 4 • 10 years ago

Removed the tree and listbox changes. Moved them to bug 1087618

	Tim Nguyen :ntim Assignee
	Comment 5 • 10 years ago

Comment on attachment 8520832 [details] [diff] [review]
Patch v3

Review of attachment 8520832 [details] [diff] [review]:
-----------------------------------------------------------------

Need to rebase this on top of bug 1062127

	Tim Nguyen :ntim Assignee
	Comment 6 • 10 years ago

Rebased.

	Dão Gottwald [:dao]
	Comment 7 • 10 years ago

Comment on attachment 8521389 [details] [diff] [review]
Patch v4

>-}
>+}
>\ No newline at end of file

Please fix this throughout the patch.

	Tim Nguyen :ntim Assignee
	Comment 8 • 10 years ago

Restored newlines at end of files

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/8ce7d46f1f99

	Camelia Badau [:cbadau], Desktop QA
	Comment 10 • 9 years ago

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Firefox 36 Beta 3 (buildID: 20150122214638).