Closed
Bug 1087394
Opened 10 years ago
Closed 9 years ago
expose browser, browser_version, browser_platform to response view
Categories
(Input Graveyard :: Dashboard, defect)
Input Graveyard
Dashboard
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: aokoye)
References
Details
(Whiteboard: u=user c=dashboard p= s=input.2014q4)
Input infers several values from the user agent if it's provided. This information should be public. This covers adding the browser, browser_version and browser_platform fields to the response view. The values in these fields is inferred from the user agent, but not considered PII.
Reporter | ||
Updated•9 years ago
|
Whiteboard: u=user c=dashboard p= s=input.2014q4 → u=user c=dashboard p= s=input.adam
Reporter | ||
Comment 1•9 years ago
|
||
The template for this is at fjord/analytics/templates/analytics/response.html . This information is all inferred from the user agent, so it's not PII. Thus we can stick it in the "public" section of that page. Maybe put these three things right after "Campaign". We don't need to have unit tests for this, but we should verify that the information is showing up correctly. To do that, add some feedback and then make sure that response has the correct stuff showing.
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → aokoye
Reporter | ||
Comment 2•9 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/415 Landed in master: https://github.com/mozilla/fjord/commit/8f622cfcd78b8cd993ab02df8d359d0a7a3d77b1 https://github.com/mozilla/fjord/commit/c4b6f85b4542f5d44d5df218b286c9836c334685 Pushed this to prod just now and verified it's working. Yay! Retro-actively marking myself as mentor. Marking as FIXED. Thank you! Great work!
Mentor: willkg
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 3•9 years ago
|
||
Undoing the mentor flag. Adam's an OPW intern. After discussing with r1cky, we think that's not not quite what the mentor flag is for.
Mentor: willkg
Reporter | ||
Updated•9 years ago
|
Whiteboard: u=user c=dashboard p= s=input.adam → u=user c=dashboard p= s=input.2014q4
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•