Closed
Bug 1087387
Opened 10 years ago
Closed 10 years ago
add browser_platform field
Categories
(Input Graveyard :: Submission, defect, P1)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
(Whiteboard: u=analyzer c=data p=2 s=input.2014q4)
We added "platform" as a field to the POST API which means that sometimes it's inferred from the user agent and sometimes it's not. This bug covers: 1. add a browser_platform field which we'll put inferred data in. 2. update the documentation in the Response model regarding what is inferred and what isn't 3. update the generic form to infer the platform from the user agent and put that in the platform and browser_platform fields
Assignee | ||
Comment 2•10 years ago
|
||
Added the field in PR: https://github.com/mozilla/fjord/pull/386
Assignee | ||
Comment 3•10 years ago
|
||
Landed in https://github.com/mozilla/fjord/commit/91538027feef92ff655ee5b332049441612f2cbd Fixed the generic feedback form to infer the browser_platform from the user_agent and put it in the browser_platform field and the platform field where appropriate. In PR: https://github.com/mozilla/fjord/pull/387
Assignee | ||
Comment 4•10 years ago
|
||
The browser_platform handling code landed in master in: https://github.com/mozilla/fjord/commit/f5d8b56e66be781eb1a5a8a6c2405a0ea4e79d8b
Assignee | ||
Comment 5•10 years ago
|
||
Pushed this to prod just now.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Whiteboard: u=analyzer c=data p= s=input.2014q4 → u=analyzer c=data p=2 s=input.2014q4
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•