Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Description • 10 years ago

If you do a search that doesn't bring up any results, then there's no facet data. Because we tie the filter ui with facet data, if there's no facet data, then there's no way to clear a filter without futzing with the querystring.

Cheng's STR:

1. go to https://input.mozilla.org/
2. click on "Firefox" product
3. click on "OSX" platform
4. search for something that doesn't bring up results

Outcome: The facets on the left side are all blank, so you can't uncheck a filter you have enabled.

Expected: Need a way to be able to clear filters when you've drilled down to a state where there are no results.


This affects both the public and analyzer's search dashboards.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 1 • 10 years ago

This is annoying, but it's not something that *has* to get fixed soon. I'm going to stick it in this quarter in case I have time for it.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 2 • 10 years ago

Possible solutions off the top of my head while I'm thinking about this before I stop thinking about this to work on EU stuff again:

1. Make sure the selected filters show up in the bar with 0 values so they can be unchecked.

2. Add a "Clear filter" thing for each section.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 3 • 10 years ago

I thought about this some more and I think the user experience and flow works better with option 1.

So I think the way we should fix this is to make sure that a selected filter shows up in the bar even if it has 0 count.

https://github.com/mozilla/fjord/blob/master/fjord/analytics/views.py#L351

"filter_data" is the data structure that we generate the facet filter sidebar from. It gets populated with transformations of data in "counts". I think the easy way to fix this is to add some code that runs just before we build "filter_data", makes sure the value being filtered is in "counts" and if not, adds it with a value of 0. If we do that, I think then the rest of the code runs and it'll all just work out magically.

This is all in Python land.

You probably want to see what "counts" looks like when the dashboard view runs first and then figure out how to insert the things that need to be in there.

We'll also want to have a test to make sure when the filter value is zero, a filter entry in the sidebar still shows up.

The tests for the dashboard view are in:

https://github.com/mozilla/fjord/blob/master/fjord/analytics/tests/test_views.py

You'll want to use PyQuery to help you figure out if the filter that you want to be there is there and has a value of 0.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 4 • 10 years ago

Bumping this to 2015q1 because we're out of time for this quarter.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 5 • 9 years ago

The description and comments should cover the problem and what needs to be done to fix it.

Marking this as a mentored bug. If you're interested in working on it, please read through our "Join this project" guide [1], complete the list of things you need to do before contributing and then add a comment to this bug asking to have it assigned to you.

If you have any questions, please ask in the bug comments, on the mailing list or in the #input channel on irc.mozilla.org.

[1] http://fjord.readthedocs.org/en/latest/welcome.html

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 6 • 9 years ago

In a PR: https://github.com/mozilla/fjord/pull/481

Landed in master: https://github.com/mozilla/fjord/commit/39f3d25ce333cb0e01646ac951a21c9131353055

I'll push this out on Monday.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 7 • 9 years ago

Pushed to prod just now. Thank you!

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 8 • 9 years ago

Reopening because lguruprasad found an issue with the happy/sad filter:

<guruprasad> the fix of mine regarding filters that you deployed today
<guruprasad> it has a minor issue
<guruprasad> it looks like when filtering on happy/sad and using a search term that yields 0 results
<guruprasad> the correct filter is not being set in the sidebar.
<guruprasad> So can you please reopen the bug?
<guruprasad> I will work on it and fix it
<guruprasad> From my testing, it works fine for other types of filters

	L. Guruprasad Assignee
	Comment 9 • 9 years ago

In a pull request - https://github.com/mozilla/fjord/pull/486

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 10 • 9 years ago

Landed in master https://github.com/mozilla/fjord/commit/8d8ee3198ff247179e4308ffdaac3bf0e7a297cc

I'll push this in the next deploy.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 11 • 9 years ago

Pushed the last bit to prod just now. Marking as FIXED.