Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 10 years ago

Go through requirements/requirements.txt and change as many "install-from-github-tarball" items to pinned requirements as we can.

The "install-from-github-tarball" items need to be installed every time you run peep plus in many cases, they're not released versions of those packages.

Note: For every item we switch, make doubly sure we've got the same version of the library and we're not inadvertently switching to a different version.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 10 years ago

Bumping this to 2015q1 because we're out of time for this quarter.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 9 years ago

Further, we also need to fix every github tarball url to have a version. e.g.:

https://github.com/gengo/gengo-python/archive/8388e35e6ef1ae946a39268763e741d82650f190.tar.gz#egg=gengo-python==1.2.3

For github tarball urls where we're picking an arbitrary commit, we should find the most recent released version in the parentage and then add ".1" to it. e.g. x.y.z.1. This makes it possible for us to "upgrade" to another arbitrary commit in the future or a released version.

	Ricky Rosario [:rrosario, :r1cky]
	Comment 3 • 9 years ago

Gonna make a pass at this.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 4 • 9 years ago

Ricky did a pass and fixed requirements that were github tarball urls for specific tags.

PR: https://github.com/mozilla/fjord/pull/505

Landed in master: https://github.com/mozilla/fjord/commit/ac35deba1def111101fe1607f826b0d1d5cc01df

Outstanding:

1. Need to go through and figure out the rest of the requirements. Can we move to a released version? Can we ditch it? If neither of those is "yes", then we need to tag it with a version. Looks like there are 15 of them, so that kind of sucks.

2. Plus we might as well sort the file alphabetically so it's easier to find things.

	Ricky Rosario [:rrosario, :r1cky]
	Comment 5 • 9 years ago

Unassigning myself in case somebody can work on the rest of this before I can.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 6 • 9 years ago

Changed another bunch of requirements from github urls to pypi equivalents.

In a PR: https://github.com/mozilla/fjord/pull/507

The ones that are left are in one of two boats:

1. Pretty sure they're not used. So we need to verify that, then remove them.

2. They're a commit that's between versions. For some we can upgrade to the next version. For some we can relieve ourselves of the requirement by changing our code. For some we'll have to live with mediocrity.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 7 • 9 years ago

The PR in comment #6 landed in master: https://github.com/mozilla/fjord/commit/89dbb49ed3285f2275b997019ae74539a73562ae

There are like 10 more to look into still.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 8 • 9 years ago

Oh, whoops! Thought I had set up the blocking already. This blocks work on bug #1137023.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 9 • 9 years ago

Updated gengo-python from some commit near 0.1.14 to released version 0.1.19.

In a PR: https://github.com/mozilla/fjord/pull/513

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 10 • 9 years ago

Removed nuggets and pinned tower and django-celery which don't get released anymore.

In a PR: https://github.com/mozilla/fjord/pull/514

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 11 • 9 years ago

PR 513 landed in master in https://github.com/mozilla/fjord/commit/e33cf9f9e8fa326a58e73deceb4dcdac745c3689

Pushed it to prod just now.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 12 • 9 years ago

PR 513 landed in https://github.com/mozilla/fjord/commit/4a8de81acb0f21c2fff78479ebf331f8718238b3

Pushed it to prod just now. SEE YA NUGGETS!

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 13 • 9 years ago

PR for updating django-multidb-router: https://github.com/mozilla/fjord/pull/517

Landed in master: https://github.com/mozilla/fjord/commit/ae5cb134fb4b775ff0462a8dab2d4d1df78723cf

Also, I pinned a bunch of requirements we'll have to use github urls for.

I think there are only a few left that need looking at.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 14 • 9 years ago

Pushed out the multidb-router update just now.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 15 • 9 years ago

This nixes django-compressor: https://github.com/mozilla/fjord/pull/518

After that, there's just django-sha2 to look into. Then I want to alphabetize the file. Then we're as done as we can be.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 16 • 9 years ago

https://github.com/mozilla/fjord/commit/649b1362bb7a7d6d5833e3fc7db8c255851bb87e

I think I'm going to ignore the django-sha2 stuff for now. It's not imperative we remove it.

Given that, marking this bug FIXED.