Closed
Bug 1041703
Opened 10 years ago
Closed 10 years ago
drop prodchan column from feedback Response model/db-table
Categories
(Input Graveyard :: Code Quality, defect)
Input Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
Details
(Whiteboard: u=dev c=codequality p=1 s=input.2014q4)
Pretty sure we don't use the prodchan column. It was intended to make it easier to group the data, but it's never been calculated correctly and it's just cruft at this point. This bug covers making sure no one uses it and if so, removing the column, the code to calculate it, the tests and the code that indexes it.
Assignee | ||
Comment 1•10 years ago
|
||
Grabbing this now. Pinged UA folks to see if anyone uses it. If not, I'll remove it. One less thing to deal with.
Assignee: nobody → willkg
Whiteboard: u=dev c=codequality p= s=input.2014q4
Assignee | ||
Comment 2•10 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/358
Assignee | ||
Comment 3•10 years ago
|
||
Landed in https://github.com/mozilla/fjord/commit/fc24371c612b07e47d3a5933e9dfcd77d11bf9e4 That migration is going to take a while to run, so I'll push this out later today when Input is in a "low point".
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•10 years ago
|
||
Making this a one-pointer.
Whiteboard: u=dev c=codequality p= s=input.2014q4 → u=dev c=codequality p=1 s=input.2014q4
Assignee | ||
Comment 5•10 years ago
|
||
Pushed to prod just now.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•