Closed Bug 1041622 Opened 10 years ago Closed 10 years ago

dump unrecognized querystring args into db (generic form)

Categories

(Input Graveyard :: Submission, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

(Whiteboard: u=user c=feedback p=2 s=input.2014q3)

It would be handy to provide additional arbitrary contextual data and have that data be saved along with the feedback response.

For the generic feedback form, we can provide this data in the querystring for the url. Unrecognized parameters would get dumped to a JSON dict of key/value pairs and saved to the db.

There are several possible issues here:

1. We don't want to be abused, so we should restrict the data we're saving.

   Maybe something like this?:

   1. keys have a maximum length of 20 characters
   2. values have a maximum length of 100 characters
   3. maximum number of keys saved of 20

   We can adjust restrictions as we go along--this wouldn't need to be set
   in stone.

2. This data could contain private information--we have no way of
   screening it. Therefore we should dump it in a separate table from the
   main response.

   For now, we shouldn't index it, either.
I think this is probably a day or two of work. Grabbing it because this is the infrastructure we need to support Loop.
Assignee: nobody → willkg
Priority: -- → P1
Whiteboard: u=user c=feedback p=2 s=input.2014q3
Summary: dump unrecognized querystring args into db → dump unrecognized querystring args into db (generic form)
Landed in master in https://github.com/mozilla/fjord/commit/fa0caac1

I'll push it to production tomorrow.
Status: NEW → ASSIGNED
Pushed to production. Marking this as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.