Closed Bug 1040919 Opened 10 years ago Closed 10 years ago

.o.o in version numbers

Categories

(Input Graveyard :: Submission, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

(Whiteboard: u=user c=feedback p=1 s=input.2014q3)

For some reason, we're getting 30.0.0 and 3.0 for the version number for incoming Firefox desktop responses:

https://input.mozilla.org/en-US/?product=Firefox&version=30.0

https://input.mozilla.org/en-US/?product=Firefox&version=30.0.0

We're not coalescing version numbers (or anything else for that matter), so this causes them to show up in two different facets which makes looking at all them difficult.

We should be picking 30.0 as the version number. The 30.0.0 is wrong.
Adding whiteboard data. No estimate, yet, because I have no idea what the problem is.

We pick up the version number from the user agent or from the url. I'm seeing .0.0 versions for a bunch of the versions, though. When I do "submit feedback" in nightly, I end up with 33.0a1 as the version. Ergo, I'm not sure where the 30.0.0 is coming from nor do I understand why it only happens sometimes.

This bug covers figuring that out and telling Input to knock it off.
Priority: -- → P1
Whiteboard: u=user c=feedback p= s=input.2014q3
Grabbing this one to work on now.
Assignee: nobody → willkg
Whiteboard: u=user c=feedback p= s=input.2014q3 → u=user c=feedback p=1 s=input.2014q3
Landed in master in https://github.com/mozilla/fjord/commit/60975716

Data migration fixing all the existing data in https://github.com/mozilla/fjord/commit/dcf8f919

I'll push to production later today. This will require a reindexing, too.
Pushed it just now. Verified that the data migration happened. Reindexed all the data.

Marking this as FIXED.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.