Alice0775 White Reporter
	Description • 10 years ago

Steps To Reproduce:
1. Open Preferences ( about:preferences )
2. Select Applications
3. Select an application and try to select an action
   --- dropdown appears as expected.

4. Exit browser and restart
5. Restore Previous Session
6. Try to select the action of the application which was selected at step3
   --- dropdown fails. this is bug.

Actual Results:
   Dropdown fails.
   No up/down arrow.

Expected Results:
   Dropdown should appear.

	Alice0775 White Reporter
	Comment 2 • 10 years ago

please ignore comment #1

	Alice0775 White Reporter
	Comment 3 • 10 years ago

Steps To Reproduce:
0. browser.preferences.inContent = true
1. Open Preferences ( about:preferences )
2. Select Applications
3. Select an application and try to select an action
   --- dropdown appears as expected.

4. Exit browser and restart
5. Restore Previous Session
6. Try to select the action of the application which was selected at step3
   --- dropdown fails. this is bug.

Actual Results:
   Dropdown fails.
   No up/down arrow.

Expected Results:
   Dropdown should appear.


Regression window(fx):
Good:
http://hg.mozilla.org/integration/fx-team/rev/0a2824f4e03b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140124085803
Bad:
http://hg.mozilla.org/integration/fx-team/rev/c7c63c6c2433
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140124091931
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=0a2824f4e03b&tochange=c7c63c6c2433

Regressed by: Bug 960903

	Benjamin Kerensa [:bkerensa]
	Comment 4 • 10 years ago

Tim,

Could you have a look at this?

	Matthew N. [:MattN]
	Comment 5 • 10 years ago

Alice, is there a workaround for when the user gets in this state? Can they toggle tabs or select a different row to get it to work again?

	Alice0775 White Reporter
	Comment 6 • 10 years ago

(In reply to Matthew N. [:MattN] (behind on bugmail) from comment #5)
> Alice, is there a workaround for when the user gets in this state? 

Close tab, and re-open about:preferences.

>Can they toggle tabs or select a different row to get it to work again?

No.

	Sylvestre Ledru [:Sylvestre]
	Comment 7 • 10 years ago

We are going to release in-tab preferences. Tracking to make sure it is polish.

	Tim Taubert [:ttaubert] (inactive)
	Comment 8 • 10 years ago

(In reply to Alice0775 White from comment #6)
> (In reply to Matthew N. [:MattN] (behind on bugmail) from comment #5)
> > Alice, is there a workaround for when the user gets in this state? 
> 
> Close tab, and re-open about:preferences.

Switch to another pane (e.g. "Content") and then back to "Applications" fixes it for me.

	Tim Taubert [:ttaubert] (inactive)
	Comment 9 • 10 years ago

(In reply to Tim Taubert [:ttaubert] from comment #8)
> Switch to another pane (e.g. "Content") and then back to "Applications"
> fixes it for me.

I was wrong, guess I didn't understand the STR. The row that was selected when quitting Firefox is the only one that breaks upon restart.

	Tim Taubert [:ttaubert] (inactive)
	Comment 10 • 10 years ago

If you remove the "lastSelectedType" attribute from "_list" in gApplicationsPane.init() then everything works fine. This can't be the right solution however as we implicitly persist the aforementioned attribute and even try to handle that somehow in _selectLastSelectedType().

This doesn't seem very specific to sessionstore, I can't get to this right now but it should be easy for someone else to pick up from here.

	Sylvestre Ledru [:Sylvestre]
	Comment 11 • 10 years ago

in-tab preferences are not going to be part of 33. No need to take a patch now.

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 12 • 10 years ago

AFAIK, we're not shipping in content prefs in 34 either. I'm dropping tracking for 34 and more generally for this bug.

	:Gijs (he/him) Assignee
	Comment 13 • 9 years ago

Taking this for the next iteration...

	:Gijs (he/him) Assignee
	Comment 14 • 9 years ago

I can't reproduce this (using steps from comment #0, comment #3). Alice, are you still seeing this?

I'm guessing this got fixed by our changes to the initialization of about:preferences, but I'm not sure.

	Alice0775 White Reporter
	Comment 15 • 9 years ago

(In reply to :Gijs Kruitbosch from comment #14)
> I can't reproduce this (using steps from comment #0, comment #3). Alice, are
> you still seeing this?
> 
> I'm guessing this got fixed by our changes to the initialization of
> about:preferences, but I'm not sure.

indeed, i can not reproduce on latest Nightly38.0a2.

However, I can still reproduce on latest Dev37.0a2.
https://hg.mozilla.org/releases/mozilla-aurora/rev/13bf0a02fa62
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Firefox/37.0 ID:20150210004330

	:Gijs (he/him) Assignee
	Comment 16 • 9 years ago

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=34e2d2bd7ec4&tochange=a6bbabebed2f

This was fixed by bug 1012223, it looks like. I'll ask for uplift there...

	:Gijs (he/him) Assignee
	Comment 17 • 9 years ago

Closing this out because it's fixed on trunk.