Closed Bug 1022579 Opened 10 years ago Closed 10 years ago

Help buttons in about:preferences have no icon when using High Contrast mode

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Version:
30 Branch
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 36
Iteration:
36.3

People

(Reporter: Unfocused, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Screenshot
25.67 KB, image/png
Details
FX_inContent-help-16x16.svg
877 bytes, image/svg+xml
Details
Patch
11.01 KB, patch
jaws
: review+
Details | Diff | Splinter Review
Attached image Screenshot — 
The help buttons in about:preferences just look like an square box with no icon, when using High Contrast mode. See attached screenshot.
Flags: firefox-backlog+
We can fix this by using SVG for the help icon and then using the right CSS system color values for the color of the glyph (like bug 1016405).
Michael, can you attach an SVG version of the help icon (question mark)?
Points: --- → 2
Flags: needinfo?(mmaslaney)
Whiteboard: p=2
Assignee: nobody → mmaslaney
Flags: needinfo?(mmaslaney)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Thanks for the SVG, we can use the same bug for implementation.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
Assignee: mmaslaney → nobody
Flags: qe-verify?
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Attached patch Patch — — Splinter Review 
I had to change from bg-image to list-style-image, since bg-images didn't show on high-contrast themes.
Attachment #8519471 - Flags: review?(jaws)
Attachment #8519471 - Flags: review?(jaws) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/68a30a046bc5
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/68a30a046bc5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Iteration: --- → 36.3
Verified fixed on Windows 7 64bit, Windows 8.1 64 bit and Windows 8 32bit using latest Nightly 36.0a1 (buildID: 20141127030208).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: