Closed Bug 1021155 Opened 10 years ago Closed 10 years ago

write smoketests for firefox os feedback form

Categories

(Input Graveyard :: Submission, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

(Whiteboard: u=dev c=tests p=1 s=input.2014q3)

We have a new smoketests system in smoketests/.

We have a test for the generic feedback form.

We need a test for the Firefox OS feedback form.

It should test everything in the generic form (i.e. can probably just copy those tests over with some changes) as well as providing utm_source and utm_campaign in the querystring (make sure it doesn't error out on submission).
Summary: write smoketests for firefox feedback form → write smoketests for firefox os feedback form
Bumping this to 2014q3.
Whiteboard: u=dev c=tests p=2 s=input.2014q2 → u=dev c=tests p=2 s=input.2014q3
Making this a P1 because we just got bit by not having this. I tweaked the API in such a way that it wasn't CSRF exempt anymore. The unit tests didn't point out the issue. A smoke test definitely would have.
Priority: -- → P1
Grabbing this to write a really basic smoketest to just go through the whole form and post data so I have at least something covered.
Assignee: nobody → willkg
Landed a basic smoketest in master in https://github.com/mozilla/fjord/commit/98745b5b

I implemented a single Firefox OS form test which covers the critical path and makes sure that data gets posted to the site. I also spent some time cleaning up the code. Test runtime went from ~160s to ~120s.

I added FIXMEs for tests that we could/should write, but we can push off writing those until we start making changes to the form.

Given that, I'm going to mark this as FIXED.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: u=dev c=tests p=2 s=input.2014q3 → u=dev c=tests p=1 s=input.2014q3
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.