Rabbi Hossain Assignee
	Description • 10 years ago

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140515004001

Steps to reproduce:

If we use Bangladeshi SIM cards on Firefox OS and go to Cellular & Data settings, We have to manually enter APN to access to Internet and use MMS.


Actual results:

It seems that Bangladeshi Operator APN's are not listed on Firefox OS. 
I think we need to add the Bangladeshi Operator APNs list on "/shared/resources/apn.json" & "/shared/resources/apn/apns_conf.xml" in Gaia repository to fix this issue.


Expected results:

When Bangladeshi people will use Firefox OS, it will be very much need to include the APNs in Firefox OS. Because Bangladeshi people finds it very tough to configure the APNs manually. I think it is very much important to include it.

	Evelyn Hung
	Comment 2 • 10 years ago

Comment on attachment 8423982 [details] [review]
Possible Patch To Fix This Issue

I know less about APN stuff. redirect to :jaoo.

Hi :jaoo, could you help review this patch to see if we have only data missing? Thanks!

	Rabbi Hossain Assignee
	Comment 3 • 10 years ago

Thanks :evelyn for your reply. I already saw :jaoo cc'ed him in this bug. Hope he will review and guide me regarding the patch.

	José Antonio Olivera Ortega [:jaoo]
	Comment 4 • 10 years ago

Comment on attachment 8423982 [details] [review]
Possible Patch To Fix This Issue

(In reply to Evelyn Hung [:evelyn] from comment #2)
> Comment on attachment 8423982 [details] [review]
> Possible Patch To Fix This Issue

Thanks for the patch Rabbi, see below please.

> Hi :jaoo, could you help review this patch to see if we have only data
> missing? Thanks!

We use apns_conf.xml file [1] as the main source of APNs for our apn.json APN database and we mustn't modify it. FYI we pull the apns_conf.xml file [1] from AOSP. We actually have modified (contributing to AOSP) the apns_conf.xml file [2] several times for changes we needed instead of adding them locally. Once those changes got landed we just synced up the apns_conf.xml file [1]. IMHO we should continue doing that. So, please, try to contribute the Bangladeshi Mobile Network's APNs to the AOSP APN database [2] and once them get landed we will be happy to sync up the apns_conf.xml file [1].

[1] https://github.com/mozilla-b2g/gaia/blob/master/shared/resources/apn/apns_conf.xml
[2] https://android.googlesource.com/device/sample/+/master/etc/apns-full-conf.xml

	Rabbi Hossain Assignee
	Comment 5 • 10 years ago

Thanks :jaoo ,

I will do that soon. :)

	Rabbi Hossain Assignee
	Comment 6 • 10 years ago

Btw, what will be the bug status now?

	José Antonio Olivera Ortega [:jaoo]
	Comment 7 • 10 years ago

(In reply to Rabbi Hossain from comment #6)
> Btw, what will be the bug status now?

As you guys need these APNs added to our apns.json database file let's wait them to be added to the AOSP APN database. Once these APNs get added we will use this bug to sync up databases.

	Rabbi Hossain Assignee
	Comment 8 • 10 years ago

Thanks for your information :jaoo 

Then I will contribute in AOSP source. I think the PR in gaia repo should be closed. So, I am closing the PR.

	Rabbi Hossain Assignee
	Comment 9 • 10 years ago

Hello :jaoo,

I am not so familiar with Google git repo managing system. I am also having problem to clone the AOSP repo with my unstable slow connection.

Would you like to help me to submit these APN changes in AOSP?

	José Antonio Olivera Ortega [:jaoo]
	Comment 10 • 10 years ago

(In reply to Rabbi Hossain from comment #9)
> Would you like to help me to submit these APN changes in AOSP?

I prefer you to do this as AOSP reviewers usually need a strong reason to add new APN into the database and you might provide it better than me. Moreover I've seen that changes/additions in the APN AOSP database needs to be done for people working for the carrier which owns those APNs. I hope you success in adding the APNs to the AOSP dababase otherwise we will try to have a workaround for it.

	Rabbi Hossain Assignee
	Comment 11 • 10 years ago

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #10)

Hello :jaoo,

I have checked that almost every android phones have these APNs. So, there is no valid or solid reason to add these APNs in the AOSP sources. I think they won't approve this changes. 

I told you before that I am not familiar with android sources & bug tracking system. I also didn't have internet access to test these things out. So, I was unable to submit these APN changes in AOSP sources.

> I hope you success in adding the APNs to the AOSP dababase 
> otherwise we will try to have a workaround for it.

Since, you told me that you will try to have a workaround for it. Can you please show me the way to this workaround?

We are going to have Firefox OS Launch in Bangladesh soon. Before the end of 2014. So, I think it is needed to be fixed as soon as possible.

	José Antonio Olivera Ortega [:jaoo]
	Comment 12 • 10 years ago

(In reply to Rabbi Hossain from comment #11)

> I have checked that almost every android phones have these APNs. So, there
> is no valid or solid reason to add these APNs in the AOSP sources. I think
> they won't approve this changes.

Well, the APNs you want to add might be added by the OEM when shipping Android on that country. It doesn't mean they are included in the AOSP APN database and IIRC the ones you want to add are not. IMHO these APNs could be added to the AOSP APN database.

> I told you before that I am not familiar with android sources & bug tracking
> system. I also didn't have internet access to test these things out. So, I
> was unable to submit these APN changes in AOSP sources.

Oh, that's too bad.

> Since, you told me that you will try to have a workaround for it. Can you
> please show me the way to this workaround?

In general new APNs or any APN update has been added through the corresponding change/addition to the AOSP APN database. We cannot go for the workaround until you try to add them to the AOSP APN database first. I'm not against adding them, we are just following a procedure.

> We are going to have Firefox OS Launch in Bangladesh soon. Before the end of
> 2014. So, I think it is needed to be fixed as soon as possible.

That's good news. Again if these APNs must to be added to the FxOS APN database we use we will try the same procedure which is to add them first to the AOSP database.

	Safwan Rahman (:safwan)
	Comment 13 • 10 years ago

Hi Rabbi,
Thanks for raising this issue by opening this bug. After seeing your discussion, I have opened an issue in AOSP.(1)
1. https://code.google.com/p/android/issues/detail?id=74421

	Safwan Rahman (:safwan)
	Comment 14 • 10 years ago

Hi :jaoo,
It seems that extra APN of Canada was added by bug 807312(1). So as we modified that time, can we modified this time also and add our APN in the apn.json Database?
1. https://bugzilla.mozilla.org/show_bug.cgi?id=807312

	Safwan Rahman (:safwan)
	Comment 15 • 10 years ago

For getting help in adding the APN information, and to Verify the Data, I am adding APN information as following with proper reference from the Operators' official website. Hope that the information will be helpful for submitting the patch and review the APNs.

	Safwan Rahman (:safwan)
	Comment 16 • 10 years ago

"Grameenphone"

"Internet"
carrier="GP INTERNET"
      mcc="470"
      mnc="01"
      apn="gpinternet"
      type="default,supl"
"WAP"
carrier="GP WAP"
      mcc="470"
      mnc="01"
      apn="gpwap"
      proxy="010.128.001.002"
      port="8080"
      type="default,supl"
"MMS"
carrier="GP MMS"
      mcc="470"
      mnc="01"
      apn="gpmms"
      mmsc="http://mms.gpsurf.net/servlets/mms"
      mmsproxy="010.128.001.002"
      mmsport="8080"
      type="mms"

References:
1. http://www.grameenphone.com/products-and-services/internet/get-handset-settings
2. http://www.mcc-mnc.com/

	Rabbi Hossain Assignee
	Comment 17 • 10 years ago

Updated the Patch by adding APNs on apns_conf_local.xml and also Added some more Info. Thanks to Safwan for the information of these APNs.

	Safwan Rahman (:safwan)
	Comment 18 • 10 years ago

For Verification Purpose, I am adding more Data of other operators with proper reference:
"Robi"
"Internet"
carrier="Robi-INTERNET"
      mcc="470"
      mnc="02"
      apn="internet"
      type="default,supl"
 "WAP"
  carrier="Robi-WAP"
      mcc="470"
      mnc="02"
      apn="wap"
      proxy="10.16.18.77"
      port="9028"
      type="default,supl"

"MMS"  
carrier="Robi-MMS"
      mcc="470"
      mnc="02"
      apn="wap"
      mmsc="http://10.16.18.40:38090/was"
      mmsproxy="10.16.18.77"
      mmsport="9028"
      type="mms"

References:
1. http://www.robi.com.bd/en/internet-settings
2. http://www.mcc-mnc.com/

	Safwan Rahman (:safwan)
	Comment 19 • 10 years ago

"Banglalink"

"Internet"
arrier="Banglalink-WEB"
      mcc="470"
      mnc="03"
      apn="blweb"
      type="default,supl"

"WAP"
carrier="Banglalink-WAP"
      mcc="470"
      mnc="03"
      apn="blwap"
      proxy="10.10.55.34"
      port="8799"
      type="default,supl"

"MMS"
carrier="Banglalink-MMS"
      mcc="470"
      mnc="03"
      apn="blmms"
      mmsc="http://mmsc1:10021/mmsc/01"
      mmsproxy="10.10.55.34"
      mmsport="8799"
      type="mms"

References:
1. http://www.banglalink.com.bd/en/services/banglalink-internet/settings/
2. http://www.mcc-mnc.com/

	Safwan Rahman (:safwan)
	Comment 20 • 10 years ago

"Airtel"

"Internet"
carrier="Airtel Internet"
      mcc="470"
      mnc="07"
      apn="internet"
      type="default,supl"

"WAP"
carrier="Airtel WAP"
      mcc="470"
      mnc="07"
      proxy="10.6.0.2"
      port="8080"
      apn="wap"
      type="default,supl"

"MMS"
carrier="Airtel MMS"
      mcc="470"
      mnc="07"
      apn="mms"
      mmsc="http://bd.airtel.com"
      mmsproxy="10.128.5.6"
      type="mms"

Reference: 
1. http://www.bd.airtel.com/services.php?cat_id=9&services_id=92
2. http://www.mcc-mnc.com/

	Safwan Rahman (:safwan)
	Comment 21 • 10 years ago

"Teletalk"

"Internet"
carrier="TT-INTERNET"
      mcc="470"
      mnc="04"
      apn="wap"
      type="default,supl"

"WAP"
carrier="TT-WAP"
      mcc="470"
      mnc="04"
      apn="wap"
      proxy="192.168.145.101"
      port="9201"
      type="default,supl"

"MMS"
carrier="Teletalk-MMS"
      mcc="470"
      mnc="04"
      apn="mms"
      mmsc="http://10.5.4.22:38090/was"
      mmsproxy="10.5.4.40"
      mmsport="8080"
      type="mms"

Reference: 
1. http://www.teletalk.com.bd/cpoint/3G/MMS_Internet_service.php
2. http://www.mcc-mnc.com/

	Yusuke Yamamoto
	Comment 22 • 10 years ago

Hi Rabbi,
In Japan, we have same issues that user have to enter the APN informations to use data connect.
Then, I also can provide correct Japanese APN informations, so, could I write down APN information( like Safwan )?

	Rabbi Hossain Assignee
	Comment 23 • 10 years ago

As Josea ( :jaoo ) is the reviewer of this patch. Let's wait for his opinion. I am passing this Needinfo request to :jaoo

	José Antonio Olivera Ortega [:jaoo]
	Comment 24 • 10 years ago

(In reply to Yusuke Yamamoto from comment #22)
> Hi Rabbi,
> In Japan, we have same issues that user have to enter the APN informations
> to use data connect.
> Then, I also can provide correct Japanese APN informations, so, could I
> write down APN information( like Safwan )?

File another separate bug please.

	José Antonio Olivera Ortega [:jaoo]
	Comment 25 • 10 years ago

Comment on attachment 8481147 [details] [review]
Updated the Patch

(In reply to Rabbi Hossain from comment #17)
> Created attachment 8481147 [details] [review]
> Updated the Patch
> 
> Updated the Patch by adding APNs on apns_conf_local.xml and also Added some
> more Info. Thanks to Safwan for the information of these APNs.

LGTM. r=me

Add 'Bug 1011584 - Bangladeshi Mobile Network's APN is not available in settings. r=jaoo' as commit message and land at will on a green Try.

Thanks!

	Rabbi Hossain Assignee
	Comment 26 • 10 years ago

Thanks :jaoo for giving this a r+ . I have changed the commit message. Please check.

I assume the this going to be merged on master branch (that means 2.2).
Is it possible to merge this on 1.4? Since we are releasing FxOs in this month with 1.4.

And also please assign this bug to me if possible.

	José Antonio Olivera Ortega [:jaoo]
	Comment 27 • 10 years ago

Landed on gaia master branch at:

https://github.com/mozilla-b2g/gaia/commit/187fe645ad48f18662e537409b6b044d31d70ad2

	José Antonio Olivera Ortega [:jaoo]
	Comment 28 • 10 years ago

(In reply to Rabbi Hossain from comment #26)

> I assume the this going to be merged on master branch (that means 2.2).
> Is it possible to merge this on 1.4? Since we are releasing FxOs in this
> month with 1.4.

Hey :bajaj, are still taking bug to v1.4 release? Could you let this guy know about it please? Thanks.

	Safwan Rahman (:safwan)
	Comment 29 • 10 years ago

[Blocking Requested - why for this release]: Because if this release launch in market, the users will face much problem to start using internet and receiving MMS. Operators APN will not be auto configured so the user will need to add it manually. It will be time consuming to the users and bad effect of Firefox OS in the market. While all the smartphone of the market is having APN of all operators, if Firefox OS does not have it, and users face the issue and they will regard Firefox OS in bad concept! As we always keep users in first priority, we need to do that users don't face any trouble while using Firefox OS.

	bhavana bajaj [:bajaj]
	Comment 30 • 10 years ago

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #28)
> (In reply to Rabbi Hossain from comment #26)
> 
> > I assume the this going to be merged on master branch (that means 2.2).
> > Is it possible to merge this on 1.4? Since we are releasing FxOs in this
> > month with 1.4.
> 
> Hey :bajaj, are still taking bug to v1.4 release? Could you let this guy
> know about it please? Thanks.

Yes. Hey wayne, given the impact in comment #29, what do you want do to on 1.4?

	Wayne Chang [:wchang]
	Comment 31 • 10 years ago

1.4 Bangladesh has gone out. I am not aware of any other launch to come for Bangladesh.

Leaving this change out for now, NI Vance just so he's aware in case OEMs may need to pick this up.

	Safwan Rahman (:safwan)
	Comment 32 • 10 years ago

Yes. Firefox 1.4 has gone out. But, there is good possibility to available OTA update for the device. The OEM may send OTA updates with other fixes. So if it is landed in 1.4, the users will get this update at next OTA. Therefore I am proposing it to be land in 1.4.

Wayne, if is not possible to land in 1.4, is it possible to land in 2.0?

	Wayne Chang [:wchang]
	Comment 33 • 10 years ago

[Blocking Requested - why for this release]:

Nominating for 2.0 - I think this is beneficial (though may not be necessary but the risk is low).

We're adding configurations which would otherwise be non-existence, so the worst case where the settings added are incorrect, there is still no user impact compared to without this patch.

	howie [:howie]
	Comment 34 • 10 years ago

Triage: blocking. Hi Rabbi, can you provide a 2.0 patch and request uplift approval‑gaia‑v2.0 ? thanks.

	Rabbi Hossain Assignee
	Comment 35 • 10 years ago

:howie, I have added the Patch. Please check.

	Ryan VanderMeulen [:RyanVM]
	Comment 36 • 10 years ago

Please nominate the patch for Gaia v2.1 approval as well.

	Rabbi Hossain Assignee
	Comment 37 • 10 years ago

Comment on attachment 8497430 [details] [review]
Uplift request to merge this PR in 2.0

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

	Rabbi Hossain Assignee
	Comment 38 • 10 years ago

I marked this Patch to uplift on 2.1. Is it OK?

	José Antonio Olivera Ortega [:jaoo]
	Comment 39 • 10 years ago

Comment on attachment 8497430 [details] [review]
Uplift request to merge this PR in 2.0

Unless you change the patch significantly (or e.g. the patch doesn't apply cleanly and you are force to change it) there is no need for a review request when uplifting. As I can see the patch has not changed so I'll cancel the review request.

	[:fabrice] Fabrice Desré
	Comment 40 • 10 years ago

(In reply to Rabbi Hossain from comment #38)
> I marked this Patch to uplift on 2.1. Is it OK?

You need to answer the uplift questions... thanks!

	Rabbi Hossain Assignee
	Comment 41 • 10 years ago

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A

[User impact] if declined: If declined, the users here in Bangladesh will not automatically get the APN configured in 2.0 & 2.1. Comment #29 describes it very well.

[Testing completed]: Yes it is tested and its already marged in master branch ( 2.2).

[Risk to taking this patch] (and alternatives if risky):No risk on taking this patch.

[String changes made]:No string changes made.

	bhavana bajaj [:bajaj]
	Comment 42 • 10 years ago

Comment on attachment 8497430 [details] [review]
Uplift request to merge this PR in 2.0

Please make sure to help and verify the 2.0 build once this lands.

	bhavana bajaj [:bajaj]
	Comment 43 • 10 years ago

(In reply to Rabbi Hossain from comment #41)
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): N/A
> 
> [User impact] if declined: If declined, the users here in Bangladesh will
> not automatically get the APN configured in 2.0 & 2.1. Comment #29 describes
> it very well.
> 
> [Testing completed]: Yes it is tested and its already marged in master
> branch ( 2.2).
> 
> [Risk to taking this patch] (and alternatives if risky):No risk on taking
> this patch.
> 
> [String changes made]:No string changes made.

Thanks for filling this, we request you to veirfy this patch once it lands on 2.0 to ensure its working as expected and there are no fallouts.

	Ryan VanderMeulen [:RyanVM]
	Comment 44 • 10 years ago

v2.1: https://github.com/mozilla-b2g/gaia/commit/4e80dc0b1c84444e7e7d5168e3840c7dcc966b85
v2.0: https://github.com/mozilla-b2g/gaia/commit/832f6f72978be55dfb8939d73956c22b808828e8

	Kai-Zhen Li [:seinlin][:kli]
	Comment 45 • 10 years ago

v2.0m: https://github.com/mozilla-b2g/gaia/commit/832f6f72978be55dfb8939d73956c22b808828e8

	Rabbi Hossain Assignee
	Comment 46 • 10 years ago

I have tested the this patch on 2.0, 2.1 and 2.2 . The patch is working perfectly as it should. Should I have to do anything now?

	Safwan Rahman (:safwan)
	Comment 47 • 10 years ago

Have tested the patch with all the operatora in 2.0,2.1 and 2.2 and it seems its working fine! :)
So verifying