Closed
Bug 1008890
Opened 10 years ago
Closed 10 years ago
[Messages] Thread carrier header isn't localized correctly right after language switch
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(tracking-b2g:backlog, b2g-v2.0 fixed)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: azasypkin, Assigned: azasypkin)
References
Details
(Whiteboard: [p=1][not-part-of-initial-sprint])
Attachments
(1 file)
*** Follow-up from bug 1003384, comment 24 *** STR: 1. Open thread where career header is shown (eg. "phone_type | carrier_name"); 2. Press Home button; 3. Go to the language settings and change the language; 4. Switch back to the SMS app; Expected result: you should see "localized_phone_type | carrier_name" Actual result: "localized_label_for_carrier_unknown" is shown.
Comment 1•10 years ago
|
||
And I think carrier_name is not even localized, right?
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #1) > And I think carrier_name is not even localized, right? But carrier_name is custom string entered by user, how is it going to be localized?
Comment 3•10 years ago
|
||
Right, I was confused, I really thought about the phone_type, sorry.
Assignee | ||
Comment 4•10 years ago
|
||
The solution for this bug should help to resolve bug 963013 that requires separate styling for carrier name.
Assignee | ||
Comment 5•10 years ago
|
||
Hey Steve, could you please review this patch? It's prerequisite (well, partially) for new carrier header spec for bug 963013. Thanks!
Attachment #8430959 -
Flags: review?(schung)
Assignee | ||
Updated•10 years ago
|
Blocks: sms-sprint-2
Whiteboard: [p=1] → [p=1][not-part-of-initial-sprint]
Target Milestone: --- → 2.0 S3 (6june)
Updated•10 years ago
|
blocking-b2g: --- → backlog
Comment 6•10 years ago
|
||
Comment on attachment 8430959 [details] [review] GitHub pull request URL Thanks for the all the works! r=me and please squash it for merge
Attachment #8430959 -
Flags: review?(schung) → review+
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Steve Chung [:steveck] from comment #6) > Comment on attachment 8430959 [details] [review] > GitHub pull request URL > > Thanks for the all the works! r=me and please squash it for merge Thanks for review! Travis is green, so check-in is needed :)
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/a3f9d7cac3c6c60ee29c060bef6f74e5a0e44fc2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.0:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Updated•9 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•